Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for ng-for #4533

Closed
wants to merge 1 commit into from
Closed

Documentation for ng-for #4533

wants to merge 1 commit into from

Conversation

alxhub
Copy link
Member

@alxhub alxhub commented Oct 5, 2015

No description provided.

@alxhub alxhub added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 5, 2015
@IgorMinar IgorMinar added this to the alpha-39 milestone Oct 5, 2015
* out, and unchanged rows retain any unsaved state such as user input.
*
* If the entire iterator is replaced, Angular will tear down the entire DOM and rebuild it with
* from the new iterator, even if none of the elements have changed. This is an expensive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with from --> with / from

@naomiblack naomiblack modified the milestones: alpha-39, alpha-40, alpha-41 Oct 6, 2015
* reproduce those changes in the DOM. New rows can be animated in, removed rows can be animated
* out, and unchanged rows retain any unsaved state such as user input.
*
* If the entire iterator is replaced, Angular will tear down the entire DOM and rebuild it with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is the case? If so, we actually need to change it, so it is not the case.

@alxhub alxhub added the action: merge The PR is ready for merge by the caretaker label Oct 12, 2015
@mary-poppins
Copy link

Merging PR #4533 on behalf of @alxhub to branch presubmit-alxhub-pr-4533.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 12, 2015
@vsavkin vsavkin added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 12, 2015
@naomiblack naomiblack added the action: merge The PR is ready for merge by the caretaker label Oct 12, 2015
@mary-poppins
Copy link

User @naomiblack does not have PR merging privileges.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 12, 2015
@IgorMinar
Copy link
Contributor

@alxhub please clang-reformat and merge

@naomiblack naomiblack modified the milestones: alpha-41, alpha-42 Oct 13, 2015
@naomiblack naomiblack modified the milestones: alpha-42, alpha-41 Oct 13, 2015
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Oct 18, 2015
@mary-poppins
Copy link

Merging PR #4533 on behalf of @IgorMinar to branch presubmit-IgorMinar-pr-4533.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 18, 2015
* # Change Propagation
*
* There are two reasons why `NgFor` will need to update the DOM:
* * The contents of the iterator changes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contents --> content
or
changes --> change

@vsavkin vsavkin assigned alxhub and unassigned vsavkin Oct 26, 2015
@alxhub alxhub closed this in 0abd218 Oct 29, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants