Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(docs-infra): move to circleci v2 api for aio-builds #45349

Closed
wants to merge 1 commit into from
Closed

build(docs-infra): move to circleci v2 api for aio-builds #45349

wants to merge 1 commit into from

Conversation

josephperrott
Copy link
Member

Move to the CircleCI v2 api as the authentication now fails on v1.1.

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker comp: docs-infra target: patch This PR is targeted for the next patch release labels Mar 14, 2022
@ngbot ngbot bot added this to the Backlog milestone Mar 14, 2022
@josephperrott josephperrott force-pushed the fix-aio-builds-circleci branch 3 times, most recently from 1fa7863 to 77c98ea Compare March 14, 2022 20:53
gkalpak
gkalpak approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of minor suggestions.

AFAICT, it is not the v1.1. vs v2 API use that makes the difference (since both result in the same URL for the build artifact), but the fact that the ?circle-token query param no longer works as an authentication method (and we have to switch to the Circle-Token header).

So, could you update the commit message to mention that as well (since that is the main issue causing the failure - moving off of the v1.1 API is a good change, of course, but not directly related to the failures afaict).

Could you also please update the docs to mention that you need to use a personal API token (not a Project API token) and update the instructions on how to create it 🙏

aio/aio-builds-setup/dockerbuild/scripts-js/lib/common/circle-ci-api.ts Outdated Show resolved Hide resolved
aio/aio-builds-setup/dockerbuild/scripts-js/lib/common/circle-ci-api.ts Outdated Show resolved Hide resolved
aio/aio-builds-setup/dockerbuild/scripts-js/lib/preview-server/build-retriever.ts Outdated Show resolved Hide resolved
@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Mar 15, 2022
@josephperrott
build(docs-infra): move to circleci v2 api for aio-builds
6523c9e 
Move to the CircleCI v2 api as the authentication fails for downloading artifacts using the v1 methods.

CircleCI v2 api now requires authentication to occur view the headers instead of being done in a
query parameter, all of the CircleCI interactions are now performed through one fetchFromCircleCi method
which ensures the token is provided in the headers as expected.
@alan-agius4
Copy link
Contributor

ci/circleci: aio_preview seems to be still be failing even with these changes.

@gkalpak
Copy link
Member

gkalpak commented Mar 17, 2022

@alan-agius4, for these changes to take effect they need to be deployed to the preview server, which will automatically happen after this PR has been merged. (There is a cron job that pulls the latest changes from master every 30 mins and updates the preview server.)

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 17, 2022
@gkalpak
Copy link
Member

gkalpak commented Mar 17, 2022

merge-assistance: The failing aio_preview and size CI checks are unrelated to this PR. (In fact, merging this PR is necessary to fix the aio_preview failures 😃)

@alxhub
Copy link
Member

alxhub commented Mar 17, 2022

This PR was merged into the repository by commit a049840.

alxhub pushed a commit that referenced this pull request Mar 17, 2022
@josephperrott @alxhub
build(docs-infra): move to circleci v2 api for aio-builds (#45349)
e5300d6 
Move to the CircleCI v2 api as the authentication fails for downloading artifacts using the v1 methods.

CircleCI v2 api now requires authentication to occur view the headers instead of being done in a
query parameter, all of the CircleCI interactions are now performed through one fetchFromCircleCi method
which ensures the token is provided in the headers as expected.

PR Close #45349
@alxhub alxhub closed this in a049840 Mar 17, 2022
gkalpak added a commit to gkalpak/angular that referenced this pull request Mar 18, 2022
@gkalpak
fix(docs-infra): update (and unpin) dependency versions for preview s…
7b825d5 
…erver

Update the `Dockerfile` used to create the preview server to use the
latest stable version of Debian (`bullseye`) and also update package
versions to latest versions.

Also, unpin the versions of installed packages (except for Node.js
related ones) as pinning proved problematic due to many packages
removing old versions from the official repositories.

NOTE:
This change will allow the preview server to be updated on the VM and
take advantage of recent fixes, such as angular#45349. Currently, the update
fails with the error:
```
E: Version '7.64.0-4+deb10u1' for 'curl' was not found
The command '/bin/sh -c apt-get update -y && apt-get install -y curl=7.64.0-4+deb10u1' returned a non-zero code: 100
```
@gkalpak gkalpak mentioned this pull request Mar 18, 2022
Closed
arturovt pushed a commit to arturovt/angular that referenced this pull request Mar 19, 2022
@josephperrott @arturovt
build(docs-infra): move to circleci v2 api for aio-builds (angular#45349
1698e40 
)

Move to the CircleCI v2 api as the authentication fails for downloading artifacts using the v1 methods.

CircleCI v2 api now requires authentication to occur view the headers instead of being done in a
query parameter, all of the CircleCI interactions are now performed through one fetchFromCircleCi method
which ensures the token is provided in the headers as expected.

PR Close angular#45349
arturovt pushed a commit to arturovt/angular that referenced this pull request Mar 19, 2022
@josephperrott @arturovt
build(docs-infra): move to circleci v2 api for aio-builds (angular#45349
4375e95 
)

Move to the CircleCI v2 api as the authentication fails for downloading artifacts using the v1 methods.

CircleCI v2 api now requires authentication to occur view the headers instead of being done in a
query parameter, all of the CircleCI interactions are now performed through one fetchFromCircleCi method
which ensures the token is provided in the headers as expected.

PR Close angular#45349
dylhunn pushed a commit that referenced this pull request Mar 24, 2022
@gkalpak @dylhunn
fix(docs-infra): update (and unpin) dependency versions for preview s…
f671dd5 
…erver (#45390)

Update the `Dockerfile` used to create the preview server to use the
latest stable version of Debian (`bullseye`) and also update package
versions to latest versions.

Also, unpin the versions of installed packages (except for Node.js
related ones) as pinning proved problematic due to many packages
removing old versions from the official repositories.

NOTE:
This change will allow the preview server to be updated on the VM and
take advantage of recent fixes, such as #45349. Currently, the update
fails with the error:
```
E: Version '7.64.0-4+deb10u1' for 'curl' was not found
The command '/bin/sh -c apt-get update -y && apt-get install -y curl=7.64.0-4+deb10u1' returned a non-zero code: 100
```

PR Close #45390
dylhunn pushed a commit that referenced this pull request Mar 24, 2022
@gkalpak @dylhunn
fix(docs-infra): update (and unpin) dependency versions for preview s…
b481eab 
…erver (#45390)

Update the `Dockerfile` used to create the preview server to use the
latest stable version of Debian (`bullseye`) and also update package
versions to latest versions.

Also, unpin the versions of installed packages (except for Node.js
related ones) as pinning proved problematic due to many packages
removing old versions from the official repositories.

NOTE:
This change will allow the preview server to be updated on the VM and
take advantage of recent fixes, such as #45349. Currently, the update
fails with the error:
```
E: Version '7.64.0-4+deb10u1' for 'curl' was not found
The command '/bin/sh -c apt-get update -y && apt-get install -y curl=7.64.0-4+deb10u1' returned a non-zero code: 100
```

PR Close #45390
PiyushAgrawal1243 pushed a commit to PiyushAgrawal1243/angular that referenced this pull request Mar 30, 2022
@josephperrott @PiyushAgrawal1243
build(docs-infra): move to circleci v2 api for aio-builds (angular#45349
27ed00b 
)

Move to the CircleCI v2 api as the authentication fails for downloading artifacts using the v1 methods.

CircleCI v2 api now requires authentication to occur view the headers instead of being done in a
query parameter, all of the CircleCI interactions are now performed through one fetchFromCircleCi method
which ensures the token is provided in the headers as expected.

PR Close angular#45349
PiyushAgrawal1243 pushed a commit to PiyushAgrawal1243/angular that referenced this pull request Mar 30, 2022
@gkalpak @PiyushAgrawal1243
fix(docs-infra): update (and unpin) dependency versions for preview s…
2bc0ad8 
…erver (angular#45390)

Update the `Dockerfile` used to create the preview server to use the
latest stable version of Debian (`bullseye`) and also update package
versions to latest versions.

Also, unpin the versions of installed packages (except for Node.js
related ones) as pinning proved problematic due to many packages
removing old versions from the official repositories.

NOTE:
This change will allow the preview server to be updated on the VM and
take advantage of recent fixes, such as angular#45349. Currently, the update
fails with the error:
```
E: Version '7.64.0-4+deb10u1' for 'curl' was not found
The command '/bin/sh -c apt-get update -y && apt-get install -y curl=7.64.0-4+deb10u1' returned a non-zero code: 100
```

PR Close angular#45390
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 17, 2022
@josephperrott josephperrott deleted the fix-aio-builds-circleci branch August 31, 2023 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josephperrott @alan-agius4 @gkalpak @alxhub