Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs (router): fixes typo on segments #45411

Closed
wants to merge 1 commit into from

Conversation

mkanyar
Copy link
Contributor

@mkanyar mkanyar commented Mar 22, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented Mar 22, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@mkanyar mkanyar changed the title Fix typo on segments docs (router): fixes typo on segments Mar 22, 2022
@atscott atscott added comp: docs area: router target: patch This PR is targeted for the next patch release labels Mar 22, 2022
@atscott
Copy link
Contributor

atscott commented Mar 22, 2022

@mkanyar LGTM. Please follow #45411 (comment) to sign the CLA so this can be merged

@ngbot ngbot bot added this to the Backlog milestone Mar 22, 2022
@AndrewKushnir AndrewKushnir removed their request for review March 22, 2022 17:18
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker labels Mar 23, 2022
@mkanyar
Copy link
Contributor Author

mkanyar commented Mar 23, 2022

@mkanyar LGTM. Please follow #45411 (comment) to sign the CLA so this can be merged

I already signed it

@dylhunn
Copy link
Contributor

dylhunn commented Mar 24, 2022

This PR was merged into the repository by commit 85782e6.

dylhunn pushed a commit that referenced this pull request Mar 24, 2022
@dylhunn dylhunn closed this in 85782e6 Mar 24, 2022
PiyushAgrawal1243 pushed a commit to PiyushAgrawal1243/angular that referenced this pull request Mar 30, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2022
@mkanyar mkanyar deleted the fix-typo-segments branch April 28, 2022 00:00
@mkanyar mkanyar restored the fix-typo-segments branch April 28, 2022 00:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: router target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants