Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): Make UntypedFormBuilder assignable to FormBuilder, and vice versa. #45421

Closed
wants to merge 1 commit into from
Closed

fix(forms): Make UntypedFormBuilder assignable to FormBuilder, and vice versa. #45421

wants to merge 1 commit into from

Commits on Mar 23, 2022

  1. fix(forms): Make UntypedFormBuilder assignable to FormBuilder, and vi… 

    …ce versa.

There was a subtle bug involving the opt-out class for FormBuilder, which I discovered during the ongoing migration. The types must be structurally the same, because people pass around FormBuilders, in addition to passing around the controls they produce. This PR ensures FormBuilder and UntypedFormBuilder are assignable to each other.
    @dylhunn
    dylhunn committed Mar 23, 2022
    Copy the full SHA
    a5d978c View commit details
    Browse the repository at this point in the history