Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add angular#bundler to Enforcing Trusted Types section #45450

Closed
wants to merge 1 commit into from
Closed

docs: add angular#bundler to Enforcing Trusted Types section #45450

wants to merge 1 commit into from

Conversation

tomeustace
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

gkalpak
gkalpak previously approved these changes Mar 26, 2022
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @tomeustace 👍

Can you please update the commit message to include Fixes #44647 at the bottom (per out commit message guidelines).

@gkalpak gkalpak added type: bug/fix action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews comp: docs area: security Issues related to built-in security features, such as HTML sanitation target: patch This PR is targeted for the next patch release labels Mar 26, 2022
@ngbot ngbot bot added this to the Backlog milestone Mar 26, 2022
@tomeustace
Copy link
Contributor Author

Thanks @gkalpak I've ammended the commit message.

@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 29, 2022
josephperrott
josephperrott previously approved these changes Apr 4, 2022
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-security

alxhub
alxhub previously approved these changes Apr 11, 2022
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: fw-security

A non-blocking request: please add additional context to the commit message, detailing why we're adding this new entry to the list.

@jessicajaniuk jessicajaniuk removed the request for review from jelbourn April 11, 2022 17:09
@jessicajaniuk
Copy link
Contributor

@tomeustace If you can rebase this and resolve the conflicts, we can get this landed.

When a Content Security Policy is defined that uses trusted-types in an application that uses lazy chunk files, ng
serve will be broken as angular#bundler entry needs to be added to
Content Security Policy.

Fixes #44647
@tomeustace
Copy link
Contributor Author

@jessicajaniuk @alxhub thanks, have performed rebase and updated commit message.

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: fw-security

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-security

@jessicajaniuk jessicajaniuk removed the request for review from pkozlowski-opensource June 10, 2022 15:42
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 10, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit adb21a2.

jessicajaniuk pushed a commit that referenced this pull request Jun 10, 2022
When a Content Security Policy is defined that uses trusted-types in an application that uses lazy chunk files, ng
serve will be broken as angular#bundler entry needs to be added to
Content Security Policy.

Fixes #44647

PR Close #45450
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: security Issues related to built-in security features, such as HTML sanitation target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants