New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add angular#bundler to Enforcing Trusted Types section #45450
docs: add angular#bundler to Enforcing Trusted Types section #45450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, @tomeustace 👍
Can you please update the commit message to include Fixes #44647
at the bottom (per out commit message guidelines).
Thanks @gkalpak I've ammended the commit message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: fw-security
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: fw-security
A non-blocking request: please add additional context to the commit message, detailing why we're adding this new entry to the list.
@tomeustace If you can rebase this and resolve the conflicts, we can get this landed. |
When a Content Security Policy is defined that uses trusted-types in an application that uses lazy chunk files, ng serve will be broken as angular#bundler entry needs to be added to Content Security Policy. Fixes #44647
@jessicajaniuk @alxhub thanks, have performed rebase and updated commit message. |
ae36b4d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
reviewed-for: fw-security
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: fw-security
This PR was merged into the repository by commit adb21a2. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information