New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docs-infra): introduce new process for generating data for the events page #45588
Conversation
You can preview 6ca41c3 at https://pr45588-6ca41c3.ngbuilds.io/. |
6ca41c3
to
832adb0
Compare
You can preview 832adb0 at https://pr45588-832adb0.ngbuilds.io/. |
832adb0
to
a551b54
Compare
You can preview a551b54 at https://pr45588-a551b54.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two comments. Looks really well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: size-tracking
a551b54
to
ed461dc
Compare
You can preview ed461dc at https://pr45588-ed461dc.ngbuilds.io/. |
ed461dc
to
fcce55c
Compare
You can preview fcce55c at https://pr45588-fcce55c.ngbuilds.io/. |
You can preview c4cb9f7 at https://pr45588-c4cb9f7.ngbuilds.io/. |
7ea2e24
to
8573647
Compare
You can preview 8573647 at https://pr45588-8573647.ngbuilds.io/. |
581ed52
to
9ec7d45
Compare
…events page This commit introduces a new process for generating data for the AIO [events page](https://angular.io/events), which streamlines the process and minimizes duplication and manual work. For more details, see `aio/scripts/generate-events/README.md`.
…or the events page
You can preview 9ec7d45 at https://pr45588-9ec7d45.ngbuilds.io/. |
Merge-assistance: needs a "green light" from @mgechev before landing this PR. |
This PR was merged into the repository by commit c9241fd. |
…events page (#45588) This commit introduces a new process for generating data for the AIO [events page](https://angular.io/events), which streamlines the process and minimizes duplication and manual work. For more details, see `aio/scripts/generate-events/README.md`. PR Close #45588
@gkalpak Was this PR related to |
Yes. As discussed "offline", notifications for scheduled workflows go to the last person that modified the schedule: GitHub docs Once the errors are fixed, hopefully there won't be any notifications 😁 |
…events page (angular#45588) This commit introduces a new process for generating data for the AIO [events page](https://angular.io/events), which streamlines the process and minimizes duplication and manual work. For more details, see `aio/scripts/generate-events/README.md`. PR Close angular#45588
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR introduces a new process for generating data for the AIO events page, which streamlines the process and minimizes duplication and manual work. For more details, see
aio/scripts/generate-events/README.md
.TODECIDE
Starts on
prefix).We will use the
YYYY-MM-DD
format and change the column header to "Start date"The current behavior is fine.
We can do that, but we also don’t have links for all the events. We’ll try to be mindful for 2022 events from now on. It’s fine if we don’t have links for all the events from the start.
(We could keep them all in the DB, but not put them in
events.json
for displaying in AIO.)For now, we will display all events (since 2019). In the future, we might want to revisit this and only show a limited number of years or show all available years but as collapsibles.
We’re good until 2019.
next.angular.io
on upstream CI and getnext.angular.io/generated.events.json
for other builds.(This would allow us to lock down reading on the database fwiw.)
We'll go with the current implementation for simplicity. We can revisit in the future if the number of reads becomes problematic.
TODO
angular-io
Firebase project.DB_URL
value inconstants.js
andindex.mjs
.PR: feat(github-actions): implement GitHub Action for creating a PR from local changes dev-infra#738
aio/content/marketing/events-contributing.md
.aio/scripts/generate-events/README.md
..github/workflows/update-events.yml
.aio-payloads.json
.