fix(router): Remove unused string type for ActivatedRoute.component #45625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
alxhub,
AndrewKushnir,
jelbourn and
jessicajaniuk
|
TGP train |
AndrewKushnir
approved these changes
Apr 14, 2022
AndrewKushnir
approved these changes
Apr 14, 2022
BREAKING CHANGE: The type of `component` on `ActivatedRoute` and `ActivatedRouteSnapshot` includes `string`. In reality, this is not the case. The component cannot be anything other than a component class.
atscott
force-pushed
the
removeStringComponent
branch
from
a25f826
to
909369f
Compare
|
green TGP with local mods |
jessicajaniuk
approved these changes
Apr 14, 2022
dylhunn
approved these changes
Apr 14, 2022
|
Note: Adding blocked label until g3 is cleaned up |
|
TGP rerun after fixes |
atscott
added
target: major
|
merge assistance: I can't dismiss the extra reviewers |
|
This PR was merged into the repository by commit 989e840. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of
componentonActivatedRouteandActivatedRouteSnapshotincludes
string. In reality, this is not the case. The componentcannot be anything other than a component class.
Reviewers note: It's unlikely that this is actually a breaking change but I will run TGP to confirm.