Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): make e2e tests use the bundles. #4565

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions gulpfile.js
Expand Up @@ -1123,11 +1123,11 @@ gulp.task('!bundle.copy', [
'!bundle.web_worker.js.dev.deps',
'!bundle.js.sfx.dev.deps',
'!router.bundle.js.dev'
], function () {
return merge2(
gulp.src('dist/js/bundle/*').pipe(gulp.dest('dist/js/prod/es5/bundle')),
gulp.src('dist/js/bundle/*').pipe(gulp.dest('dist/js/dev/es5/bundle')));
});
],
function() {
return merge2(gulp.src('dist/js/bundle/**').pipe(gulp.dest('dist/js/prod/es5/bundle')),
gulp.src('dist/js/bundle/**').pipe(gulp.dest('dist/js/dev/es5/bundle')));
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intentional? looks like a formatting error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, that's what clang-format did and it does pass the format check. The previous code definitely didn't go through clang-format as it has function () instead of function().


gulp.task('bundles.js', [
'!bundle.js.prod.deps',
Expand Down
26 changes: 18 additions & 8 deletions tools/broccoli/html-replace/SCRIPTS.html
@@ -1,13 +1,23 @@
<script src="es6-shim.js" type="text/javascript"></script>
<script src="zone-microtask.js" type="text/javascript"></script>
<script src="long-stack-trace-zone.js" type="text/javascript"></script>
<script src="system.src.js" type="text/javascript"></script>
<script src="Reflect.js" type="text/javascript"></script>
<script type="text/javascript">
var filename = '@@FILENAME_NO_EXT';
<script src="es6-shim.js"></script>
<script src="system.src.js"></script>
<script>
System.config({
baseURL: '/',
defaultJSExtensions: true
packages: {
'angular2_material': {defaultExtension: 'js'},
'benchmarks': {defaultExtension: 'js'},
'examples': {defaultExtension: 'js'},
// TODO(rado): These helpers don't end up in the bundle, thus they should
// not even be in src/*. Move them!
'angular2/src/test_lib/benchmark_util': {defaultExtension: 'js'},
'angular2/src/core/facade/browser': {defaultExtension: 'js'},
}
});
</script>
<script src="/bundle/angular2.dev.js"></script>
<script src="/bundle/http.js"></script>
<script src="/bundle/router.dev.js"></script>
<script>
var filename = '@@PATH/@@FILENAME';
System.import(filename).then(function(m) { m.main(); }, console.error.bind(console));
</script>
26 changes: 17 additions & 9 deletions tools/broccoli/html-replace/SCRIPTS_benchmarks.html
@@ -1,14 +1,22 @@
<script src="es6-shim.js" type="text/javascript"></script>
<script src="zone-microtask.js" type="text/javascript"></script>
<script src="long-stack-trace-zone.js" type="text/javascript"></script>
<script src="url_params_to_form.js" type="text/javascript"></script>
<script src="system.src.js" type="text/javascript"></script>
<script src="Reflect.js" type="text/javascript"></script>
<script type="text/javascript">
var filename = '@@FILENAME_NO_EXT';
<script src="es6-shim.js"></script>
<script src="url_params_to_form.js"></script>
<script src="system.src.js"></script>
<script>
System.config({
baseURL: '/',
defaultJSExtensions: true
packages: {
'angular2_material': {defaultExtension: 'js'},
'benchmarks': {defaultExtension: 'js'},
'examples': {defaultExtension: 'js'},
// TODO(rado): These helpers don't end up in the bundle, thus they should
// not even be in src/*. Move them!
'angular2/src/test_lib/benchmark_util': {defaultExtension: 'js'},
'angular2/src/core/facade/browser': {defaultExtension: 'js'},
}
});
</script>
<script src="/bundle/angular2.dev.js"></script>
<script>
var filename = '@@PATH/@@FILENAME';
System.import(filename).then(function(m) { m.main(); }, console.error.bind(console));
</script>
17 changes: 8 additions & 9 deletions tools/broccoli/html-replace/SCRIPTS_benchmarks_external.html
@@ -1,15 +1,14 @@
<script src="es6-shim.js" type="text/javascript"></script>
<script src="zone-microtask.js" type="text/javascript"></script>
<script src="long-stack-trace-zone.js" type="text/javascript"></script>
<script src="angular.js" type="text/javascript"></script>
<script src="url_params_to_form.js" type="text/javascript"></script>
<script src="system.src.js" type="text/javascript"></script>
<script src="Reflect.js" type="text/javascript"></script>
<script type="text/javascript">
var filename = '@@FILENAME_NO_EXT';
<script src="es6-shim.js"></script>
<script src="zone-microtask.js"></script>
<script src="long-stack-trace-zone.js"></script>
<script src="angular.js"></script>
<script src="url_params_to_form.js"></script>
<script src="system.src.js"></script>
<script>
System.config({
baseURL: '/',
defaultJSExtensions: true
});
var filename = '@@PATH/@@FILENAME';
System.import(filename).then(function(m) { m.main(); }, console.error.bind(console));
</script>
29 changes: 24 additions & 5 deletions tools/broccoli/trees/browser_tree.ts
Expand Up @@ -90,9 +90,18 @@ module.exports = function makeBrowserTree(options, destinationPath) {
});

var scriptPathPatternReplacement = {
match: '@@FILENAME_NO_EXT',
match: '@@PATH',
replacement: function(replacement, relativePath) {
return relativePath.replace(/\.\w+$/, '').replace(/\\/g, '/');
var parts = relativePath.replace(/\\/g, '/').split('/');
return parts.splice(0, parts.length - 1).join('/');
}
};

var scriptFilePatternReplacement = {
match: '@@FILENAME',
replacement: function(replacement, relativePath) {
var parts = relativePath.replace(/\\/g, '/').split('/');
return parts[parts.length - 1].replace('html', 'js');
}
};

Expand Down Expand Up @@ -171,7 +180,8 @@ module.exports = function makeBrowserTree(options, destinationPath) {
files: ['examples*/**/*.html'],
patterns: [
{match: /\$SCRIPTS\$/, replacement: htmlReplace('SCRIPTS')},
scriptPathPatternReplacement
scriptPathPatternReplacement,
scriptFilePatternReplacement
]
});

Expand All @@ -180,18 +190,27 @@ module.exports = function makeBrowserTree(options, destinationPath) {
files: ['benchmarks/**'],
patterns: [
{match: /\$SCRIPTS\$/, replacement: htmlReplace('SCRIPTS_benchmarks')},
scriptPathPatternReplacement
scriptPathPatternReplacement,
scriptFilePatternReplacement
]
});

htmlTree = replace(htmlTree, {
files: ['benchmarks_external/**'],
patterns: [
{match: /\$SCRIPTS\$/, replacement: htmlReplace('SCRIPTS_benchmarks_external')},
scriptPathPatternReplacement
scriptPathPatternReplacement,
scriptFilePatternReplacement
]
});

// We need to replace the regular angular bundle with the web-worker bundle
// for web-worker e2e tests.
htmlTree = replace(htmlTree, {
files: ['examples*/**/web_workers/**/*.html'],
patterns: [{match: "/bundle/angular2.dev.js", replacement: "/bundle/web_worker/ui.dev.js"}]
});

var assetsTree =
new Funnel(modulesTree, {include: ['**/*'], exclude: ['**/*.{html,ts,dart}'], destDir: '/'});

Expand Down