docs(docs-infra): clarify toh-2 error message

[dario-piotrowicz]

the second step of the tour of heroes refers to a runtime error which
generally isn't presented to new users since it gets caught by the
TypeScript compiler's strict mode, clarify such detail so not to confuse
readers

resolves #45759

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

Issue

Issue Number: #45759

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

[AndrewKushnir]

@dario-piotrowicz thanks for the PR! I've left some comments and I also noticed that the lint CI job is failing. Could you please take a look when you get a chance? Thank you.

[AndrewKushnir]

@dario-piotrowicz the lint error is a bit weird: it complains about a file that you didn't change in this PR... May be try to rebase on top of the latest main?

[dario-piotrowicz]

@AndrewKushnir, I've addressed your comments, thank you so very much for the great review 😍

[AndrewKushnir]

I wanted to use ng-container for the *ngIf here but I thought that I would not overwhelm newcomers so kept the div what do you think? is the right call?

If I understand correctly, the <div> was already there, right? Anyway, I think it's a good idea to use a <div> during this part of the tutorial and introduce <ng-container> later.

Above in the tutorial we only say not to assign a value to the selectedHero, but we never directly say that its value is going to be undefined here I do however use the undefined keyword, I hope that it cannot lead to confusion?

I've added a suggestion to rephrase that section. Please let me know what you think.

Should I add a short explanation about how *ngIf works with truthy/falsy values? or is that clear?

I think it's clear and we can expend on it more if we get some feedback.

[dario-piotrowicz]

@AndrewKushnir thanks a lot again for the nice reviewing! 😄 , I've applied the suggestions 🙂

[AndrewKushnir]

@dario-piotrowicz thanks a lot for addressing the feedback! 👍

[dario-piotrowicz]

@dario-piotrowicz thanks a lot for addressing the feedback! +1

My pleasure! thanks again for the awesome reviewing! 😊

[AndrewKushnir]

This PR was merged into the repository by commit b6156f4.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}