Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(common): reorg e2e folders for the NgOptimizedImage directive tests #46015

Merged
merged 1 commit into from May 17, 2022

Conversation

AndrewKushnir
Copy link
Contributor

This commit updates the e2e folder to separate e2e tests and playground scripts (so it's clear where files are used).

PR Type

What kind of change does this PR introduce?

  • Other... Please describe: tests-related changes.

Does this PR introduce a breaking change?

  • Yes
  • No

…tests

This commit updates the e2e folder to separate e2e tests and playground scripts (so it's clear where files are used).
@AndrewKushnir AndrewKushnir added area: common Issues related to APIs in the @angular/common package PullApprove: disable target: feature This PR is targeted for a feature branch (outside of main and semver branches) labels May 17, 2022
@ngbot ngbot bot modified the milestone: Backlog May 17, 2022
@AndrewKushnir AndrewKushnir marked this pull request as ready for review May 17, 2022 02:26
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

@AndrewKushnir AndrewKushnir merged commit 2617a6d into angular:image-directive May 17, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: common Issues related to APIs in the @angular/common package PullApprove: disable target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants