feat(common): add cloudflare loader #46315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
PullApprove: disable
target: feature
AndrewKushnir
requested review from
pkozlowski-opensource and
AndrewKushnir
and removed request for
jessicajaniuk
intellix
reviewed
Jun 9, 2022
| throw new RuntimeError( | ||
| RuntimeErrorCode.INVALID_INPUT, | ||
| `ImgixLoader has detected an invalid path: ` + | ||
| `expecting a path like https://somepath.imgix.net/` + |
There was a problem hiding this comment.
I guess this shouldn't reference Imgix
There was a problem hiding this comment.
Good catch, thnx @intellix - I'm going to merge it as-is and send a follow-up PR since I'm planing to do a couple of cleanup moves anyway.
pkozlowski-opensource
approved these changes
Jun 9, 2022
pkozlowski-opensource
approved these changes
Jun 9, 2022
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jun 9, 2022
|
Merged as 40ea24a |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 19, 2022
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 2, 2022
AndrewKushnir
pushed a commit
that referenced
this pull request
Aug 3, 2022
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Aug 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing up as a placeholder. Will need to update to reflect #46277.
Does this PR introduce a breaking change?