refactor(router): clean up internal hooks #46321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
area: router
target: patch
* beforePreactivation hook is unused * The only place that uses afterPreactivation does not use the arguments Not to say we won't want to provide hooks similar to this in the future, but the current state is over-engineered for what it's being used for.
jessicajaniuk
approved these changes
Jun 10, 2022
|
This PR was merged into the repository by commit caa2f35. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Jun 10, 2022
* beforePreactivation hook is unused * The only place that uses afterPreactivation does not use the arguments Not to say we won't want to provide hooks similar to this in the future, but the current state is over-engineered for what it's being used for. PR Close #46321
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to say we won't want to provide hooks similar to this in the future,
but the current state is over-engineered for what it's being used for.
reviewer note: This is a resubmit of #43651 after internal cleanup