Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update angular version of in-memory-web-api #46344

Closed
wants to merge 1 commit into from
Closed

build: update angular version of in-memory-web-api #46344

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 12, 2022 •
edited

Changes the required version of Angular in angular-in-memory-web-api to version 14.0.0.

Fixes #46332.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 12, 2022
@crisbeto
build: update angular version of in-memory-web-api
7a79a91 
Changes the required version of Angular in `angular-in-memory-web-api` to version 14.0.0.

Fixes angular#46332.
@crisbeto crisbeto changed the title build: widen angular version range for in-memory-web-api build: update angular version of in-memory-web-api Jun 13, 2022
@crisbeto crisbeto force-pushed the 46332/in-memory-web-api-bump branch from 65b801a to 7a79a91 Compare June 13, 2022 16:42
@crisbeto
Copy link
Member Author

I've addressed the feedback.

pkozlowski-opensource
pkozlowski-opensource approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alan-agius4
alan-agius4 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessicajaniuk jessicajaniuk added the area: build & ci Related the build and CI infrastructure of the project label Jun 13, 2022
@ngbot ngbot bot added this to the Backlog milestone Jun 13, 2022
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 13, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit d6880c9.

jessicajaniuk pushed a commit that referenced this pull request Jun 13, 2022
@crisbeto @thePunderWoman
build: update angular version of in-memory-web-api (#46344)
a0f3c81 
Changes the required version of Angular in `angular-in-memory-web-api` to version 14.0.0.

Fixes #46332.

PR Close #46344
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

angular-in-memory-web-api Angular 14 support
4 participants
@crisbeto @jessicajaniuk @pkozlowski-opensource @alan-agius4