ci: override existing snapshot tag if publish snapshot job is restarted #46366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the snapshot publish job is manually being restarted, the tag in the snapshot repo might already exist and the job will fail. We can just forcibly re-create the tag (even if it will be at the same revision). We use force mode in a couple of other command as well, such as `git push` of the actual tag and snapshot revision/SHA.
jessicajaniuk
approved these changes
Jun 14, 2022
jessicajaniuk
added
the
area: build & ci
jessicajaniuk
added
target: patch
|
I believe we could also abort gracefully if the tag already exists, but the whole script needs some work... the tag can only be the same SHA due to our shallow clone, so it doesn't seem to matter 🤷♂️ |
gkalpak
approved these changes
Jun 15, 2022
|
This PR was merged into the repository by commit 736b545. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Jun 15, 2022
…ed (#46366) If the snapshot publish job is manually being restarted, the tag in the snapshot repo might already exist and the job will fail. We can just forcibly re-create the tag (even if it will be at the same revision). We use force mode in a couple of other command as well, such as `git push` of the actual tag and snapshot revision/SHA. PR Close #46366
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the snapshot publish job is manually being restarted, the tag in the
snapshot repo might already exist and the job will fail. We can just
forcibly re-create the tag (even if it will be at the same revision).
We use force mode in a couple of other commands as well, such as
git pushof the actual tag and snapshot revision/SHA.Arguably, there is lots of room for improvement in this script as currently it does not guarantee a linear chronological history anyway. We can improve this when we share this script in the dev-infra ORB. At the same time though, snapshots are in no way important enough for us to worry