build: remove the unused source-map-test #46518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As source-map-test is unused and obsolete at this point, removing it from the repository.
josephperrott
added
action: merge
devversion
reviewed
Jun 27, 2022
There was a problem hiding this comment.
LGTM
Capturing this here: we wanted to re-enable this and rework for a while -- #27966 (comment), but it will never be a priority. We verify our source maps with manual testing and the new compliance tests partially as well
can you also please update the pullapprove config?
devversion
approved these changes
Jun 27, 2022
devversion
added
the
action: cleanup
josephperrott
removed
the
action: cleanup
|
This PR was merged into the repository by commit d5c2169. |
dylhunn
pushed a commit
that referenced
this pull request
Jun 27, 2022
As source-map-test is unused and obsolete at this point, removing it from the repository. PR Close #46518
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As source-map-test is unused and obsolete at this point, removing it from the repository.