test(core): avoid TemplateFixture usages in render3 specs
#46571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
action: review
AndrewKushnir
force-pushed
the
render3_tests_refactor
branch
2 times, most recently
from
6e62464
to
3be9114
Compare
pkozlowski-opensource
force-pushed
the
render3_tests_refactor
branch
from
ca96ff1
to
3be9114
Compare
This commit refactors a Pipe-related test to use TestBed and moves it to the `acceptance` folder.
This commit further reduces the use of an obsolete `TemplateFixture` class.
This commit further reduces the use of an obsolete `TemplateFixture` class.
This commit updates the remaining set of tests to avoid referencing `TemplateFixture` class.
This commit removes a file that contained utils (including `TemplateFixture`) that are no longer used.
AndrewKushnir
force-pushed
the
render3_tests_refactor
branch
from
3be9114
to
1f27a04
Compare
pkozlowski-opensource
approved these changes
Jun 29, 2022
pkozlowski-opensource
added
action: merge
|
This PR was merged into the repository by commit 957744f. |
dylhunn
pushed a commit
that referenced
this pull request
Jun 29, 2022
This commit refactors a Pipe-related test to use TestBed and moves it to the `acceptance` folder. PR Close #46571
dylhunn
pushed a commit
that referenced
this pull request
Jun 29, 2022
This commit further reduces the use of an obsolete `TemplateFixture` class. PR Close #46571
dylhunn
pushed a commit
that referenced
this pull request
Jun 29, 2022
This commit further reduces the use of an obsolete `TemplateFixture` class. PR Close #46571
dylhunn
pushed a commit
that referenced
this pull request
Jun 29, 2022
This commit removes a file that contained utils (including `TemplateFixture`) that are no longer used. PR Close #46571
dylhunn
pushed a commit
that referenced
this pull request
Jun 29, 2022
This commit further reduces the use of an obsolete `TemplateFixture` class. PR Close #46571
dylhunn
pushed a commit
that referenced
this pull request
Jun 29, 2022
This commit further reduces the use of an obsolete `TemplateFixture` class. PR Close #46571
dylhunn
pushed a commit
that referenced
this pull request
Jun 29, 2022
This commit removes a file that contained utils (including `TemplateFixture`) that are no longer used. PR Close #46571
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?