Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clean-up pre-CLDR 39 safety check #46606

Closed
wants to merge 1 commit into from
Closed

refactor: clean-up pre-CLDR 39 safety check #46606

wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

This commit cleans-up/removes a check we added before we supported CLDR
39. This check was necessary due to a incomplete/invalid list of locales
provided as part of the JSON data.

@devversion
refactor: clean-up pre-CLDR 39 safety check
121138c 
This commit cleans-up/removes a check we added before we supported CLDR
39. This check was necessary due to a incomplete/invalid list of locales
provided as part of the JSON data.
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release labels Jun 29, 2022
@ngbot ngbot bot modified the milestone: Backlog Jun 29, 2022
josephperrott
josephperrott approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir AndrewKushnir removed the request for review from pkozlowski-opensource June 29, 2022 16:12
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 29, 2022
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 29, 2022
@dylhunn
Copy link
Contributor

dylhunn commented Jun 29, 2022

This PR was merged into the repository by commit b1ac3d9.

dylhunn pushed a commit that referenced this pull request Jun 29, 2022
@devversion @dylhunn
refactor: clean-up pre-CLDR 39 safety check (#46606)
e74ab2c 
This commit cleans-up/removes a check we added before we supported CLDR
39. This check was necessary due to a incomplete/invalid list of locales
provided as part of the JSON data.

PR Close #46606
@dylhunn dylhunn closed this in b1ac3d9 Jun 29, 2022
@devversion devversion self-assigned this Jul 1, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devversion @dylhunn @josephperrott @AndrewKushnir