Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zone.js): Fix ConsoleTask interface typo #47090

Closed
wants to merge 1 commit into from

Conversation

victorporof
Copy link
Contributor

@victorporof victorporof commented Aug 9, 2022

Signed-off-by: Victor Porof victorporof@chromium.org

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

This PR updates a TypeScript interface.

What is the current behavior?

ConsoleTask::run is typed as returning void.

What is the new behavior?

ConsoleTask::run is typed returning the same value from invoking the function that was passed in as an argument.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

According to the V8 implementation, the Async Stack Tagging API's task run function is transparent and equivalent to changing f() to task.run(f). The return value of f won't be lost. This PR updates the interface to reflect that.

Signed-off-by: Victor Porof <victorporof@chromium.org>
@pullapprove pullapprove bot requested a review from JiaLiPassion August 9, 2022 09:58
@ngbot ngbot bot added this to the Backlog milestone Aug 9, 2022
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Aug 9, 2022
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 9, 2022
@AndrewKushnir
Copy link
Contributor

Merge-assistance: low risk change, no additional reviews are required, we can proceed with the merge.

@dylhunn
Copy link
Contributor

dylhunn commented Aug 10, 2022

@victorprof this has merge conflicts with the patch branch. If you'd like this in patch, please create a patch port rebase, thanks!

@dylhunn dylhunn added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 10, 2022
@dylhunn
Copy link
Contributor

dylhunn commented Aug 10, 2022

This PR was merged into the repository by commit 91954cf.

@dylhunn dylhunn closed this in 91954cf Aug 10, 2022
@victorporof victorporof deleted the asttypo branch August 18, 2022 12:49
@victorporof
Copy link
Contributor Author

@victorprof this has merge conflicts with the patch branch. If you'd like this in patch, please create a patch port rebase, thanks!

Is this still needed?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: zones merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants