Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(common): update hello-world-example.html #47152

Closed
wants to merge 1 commit into from

Conversation

injune1123
Copy link

Correct an error on the what-is-angular documentation
https://angular.io/guide/what-is-angular

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Correct an error on the what-is-angular documentation
https://angular.io/guide/what-is-angular
@google-cla
Copy link

google-cla bot commented Aug 15, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jessicajaniuk
Copy link
Contributor

@injune1123 Thanks for the PR. If you take a look at the live example in the docs here and view the rendered DOM in devtools, you'll see the current example code in the docs is actually correct. It states When Angular renders this component, the resulting DOM looks like this:, and shows that example. Here's what it looks like when rendered in the DOM.
Screen Shot 2022-08-15 at 9 53 24 AM
I think your suggested fix is what you would put in the component template rather than what is rendered in the dom. Am I correct in that assumption?

@ngbot ngbot bot added this to the Backlog milestone Aug 15, 2022
@jessicajaniuk
Copy link
Contributor

I'm going to close this PR for now, but we appreciate the PR! Feel free to comment or re-open if there are additional changes here you'd like to make.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants