Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(compiler): replace most usages of getMutableClone #47167

Closed
wants to merge 2 commits into from

Conversation

crisbeto
Copy link
Member

Replaces (almost) all of the usages of the deprecated getMutableClone function from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove.

@crisbeto crisbeto force-pushed the get-mutable-clone branch 5 times, most recently from 04302bd to 0b6bc0a Compare August 17, 2022 09:14
@crisbeto crisbeto added area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release labels Aug 17, 2022
@ngbot ngbot bot modified the milestone: Backlog Aug 17, 2022
@crisbeto
Copy link
Member Author

Passing TGP

@crisbeto crisbeto added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 17, 2022
@crisbeto crisbeto marked this pull request as ready for review August 17, 2022 11:18
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the trivial tslint, but I also looked at the downlevel transform I added in the past..

@crisbeto crisbeto requested review from atscott and removed request for AndrewKushnir August 17, 2022 17:30
@pullapprove pullapprove bot removed the request for review from atscott August 17, 2022 17:30
@crisbeto crisbeto requested a review from JoostK August 17, 2022 17:30
Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

Replaces (almost) all of the usages of the deprecated `getMutableClone` function from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove.
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 19, 2022
@crisbeto crisbeto modified the milestones: Backlog, v14.2-candidates Aug 20, 2022
@alxhub
Copy link
Member

alxhub commented Aug 22, 2022

This PR was merged into the repository by commit ddb95c5.

@alxhub alxhub closed this in ddb95c5 Aug 22, 2022
crisbeto added a commit to crisbeto/angular that referenced this pull request Aug 26, 2022
…7167)

Replaces (almost) all of the usages of the deprecated `getMutableClone` function from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove.

PR Close angular#47167
alxhub pushed a commit that referenced this pull request Aug 26, 2022
…47271)

Replaces (almost) all of the usages of the deprecated `getMutableClone` function from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove.

PR Close #47167

PR Close #47271
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants