-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(compiler): replace most usages of getMutableClone #47167
Conversation
04302bd
to
0b6bc0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the trivial tslint, but I also looked at the downlevel transform I added in the past..
packages/compiler-cli/test/downlevel_decorators_transform_spec.ts
Outdated
Show resolved
Hide resolved
...mpiler-cli/src/transformers/downlevel_decorators_transform/downlevel_decorators_transform.ts
Outdated
Show resolved
Hide resolved
0b6bc0a
to
69d0bde
Compare
...mpiler-cli/src/transformers/downlevel_decorators_transform/downlevel_decorators_transform.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit
Replaces (almost) all of the usages of the deprecated `getMutableClone` function from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove.
bfbf192
to
a375b68
Compare
a375b68
to
e025da2
Compare
This PR was merged into the repository by commit ddb95c5. |
…7167) Replaces (almost) all of the usages of the deprecated `getMutableClone` function from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove. PR Close angular#47167
…47271) Replaces (almost) all of the usages of the deprecated `getMutableClone` function from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove. PR Close #47167 PR Close #47271
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Replaces (almost) all of the usages of the deprecated
getMutableClone
function from TypeScript which has started to log deprecation warnings in version 4.8 and will likely be removed in version 5.0. The one place we have left is in the default import handling of ngtsc which will be more difficult to remove.