refactor(common): post-review image directive cleanup #47170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
action: review
gkalpak
reviewed
Aug 17, 2022
There was a problem hiding this comment.
FYI, I have left a couple more minor comments in #47082 (review).
|
Thnx for the additional review @gkalpak - I've converted this PR to a draft to capture your findings. |
pkozlowski-opensource
force-pushed
the
image_post_merge_review
branch
from
7516beb
to
15eaeae
Compare
Minor cleanups based on the review comments that were not addressed after the initial review.
pkozlowski-opensource
force-pushed
the
image_post_merge_review
branch
from
15eaeae
to
278e6b3
Compare
gkalpak
approved these changes
Aug 22, 2022
pkozlowski-opensource
added
action: merge
|
This PR was merged into the repository by commit 634e6c7. |
pkozlowski-opensource
added a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Aug 23, 2022
Minor cleanups based on the review comments that were not addressed after the initial review. PR Close angular#47170
pkozlowski-opensource
added a commit
to pkozlowski-opensource/angular
that referenced
this pull request
Aug 23, 2022
Minor cleanups based on the review comments that were not addressed after the initial review. PR Close angular#47170
alxhub
pushed a commit
that referenced
this pull request
Aug 23, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanups based on the review comments that were
not addressed after the initial review.
Based on #47082 (review)