-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(common): create an NgFor
alias for NgForOf
directive
#47309
Conversation
You can preview 3f4dba1 at https://pr47309-3f4dba1.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-common
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
Should |
This commit adds a re-export of the `NgForOf` class as `NgFor` to improve the DX for cases when the directive is used as standalone. Developers can import `NgFor` class, which better matches the `ngFor` attribute used in a template.
3f4dba1
to
7b0b3d2
Compare
@JoostK great point 👍 I've updated the |
You can preview 7b0b3d2 at https://pr47309-7b0b3d2.ngbuilds.io/. |
This PR was merged into the repository by commit 710d1da. |
…gular#47309) This commit adds a re-export of the `NgForOf` class as `NgFor` to improve the DX for cases when the directive is used as standalone. Developers can import `NgFor` class, which better matches the `ngFor` attribute used in a template. PR Close angular#47309
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit adds a re-export of the
NgForOf
class asNgFor
to improve the DX for cases when the directive is used as standalone. Developers can importNgFor
class, which better matches thengFor
attribute used in a template.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?