Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scorecard badge to readme #47443

Closed
wants to merge 2 commits into from
Closed

Add Scorecard badge to readme #47443

wants to merge 2 commits into from

Conversation

diogoteles08
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

This PR adds the badge of OpenSSF Scorecard to the README of the project. It's a recent feature, has been adopted by many big projects already and helps showing off your hard work to improve security practices. Badges are especially useful for maintainers, who will be able to assess dependencies at a glance, and adopting it encourages new adopters of Scorecards and help raise the collective level of open source security.

Any doubts or questions please feel free to reach out to me.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pkozlowski-opensource pkozlowski-opensource added comp: docs area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) labels Sep 15, 2022
@ngbot ngbot bot modified the milestone: Backlog Sep 15, 2022
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 15, 2022
@devversion devversion requested review from josephperrott and removed request for devversion September 15, 2022 09:12
@jessicajaniuk
Copy link
Contributor

@diogoteles08 Can you fix your commit messages scopes? It looks like you have types but not scopes, which is causing our lint check to fail. They're the thing that goes in the (). You can find a list of valid scopes in the CONTRIBUTING.md file.

@diogoteles08
Copy link
Contributor Author

Sure! Will do that

@diogoteles08
Copy link
Contributor Author

Hi! I was able to fix the commit message issues, but seems like I'm getting another error on CircleCI that I don't think was caused by my changes. It says Sauce Connect Proxy failed to start.. Should I do anything about that?

@josephperrott
Copy link
Member

After consideration and discussing within the team, we determined we actually do not want to include the scorecard badge in our readme as the information is not actionable or inherently useful for our community without a lot of additional understanding and context.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants