Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use shared circleci dev-infra for common circleci code #47467

Closed
wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

This allows us to remove the duplicated rebase-pr.js script so that we can maintain this script in a single place.

@pkozlowski-opensource pkozlowski-opensource added area: build & ci Related the build and CI infrastructure of the project area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) labels Sep 19, 2022
@ngbot ngbot bot modified the milestone: Backlog Sep 19, 2022
@devversion devversion added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 20, 2022
@devversion devversion marked this pull request as ready for review September 20, 2022 15:57
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 23, 2022
@devversion devversion added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 24, 2022
This allows us to remove the duplicated `rebase-pr.js` script so that we can maintain this script in a single place.
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit ec1105d.

AndrewKushnir pushed a commit that referenced this pull request Sep 29, 2022
This allows us to remove the duplicated `rebase-pr.js` script so that we can maintain this script in a single place.

PR Close #47467
pterratpro pushed a commit to pterratpro/angular-fr that referenced this pull request Oct 4, 2022
…r#47467)

This allows us to remove the duplicated `rebase-pr.js` script so that we can maintain this script in a single place.

PR Close angular#47467
pterratpro pushed a commit to pterratpro/angular-fr that referenced this pull request Oct 4, 2022
…r#47467)

This allows us to remove the duplicated `rebase-pr.js` script so that we can maintain this script in a single place.

PR Close angular#47467
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants