fix(animations): make sure that the useAnimation function delay is applied #47468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plied make sure that when an animation is used via the `useAnimation` function and a delay has been provided then that delay gets correctly applied (this PR is a follow up for angular#47285)
pkozlowski-opensource
added
the
action: review
jessicajaniuk
added
target: patch
|
This PR was merged into the repository by commit d11b1d9. |
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Sep 27, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.2/14.2.3) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.2/14.2.3) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.2/14.2.3) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.2/14.2.3) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.2/14.2.3) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.2/14.2.3) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.2/14.2.3) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.2/14.2.3) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.2.3`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1423-2022-09-21) [Compare Source](angular/angular@14.2.2...14.2.3) ##### animations | Commit | Type | Description | | -- | -- | -- | | [bba2dae812](angular/angular@bba2dae) | fix | make sure that the useAnimation function delay is applied ([#​47468](angular/angular#47468)) | #### Special Thanks AleksanderBodurri, Andrew Kushnir, Andrew Scott, Bob Watson, George Kalpakas, Joey Perrott, Mauro Mattos, dario-piotrowicz, fabioemoutinho and famzila <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDEuMSIsInVwZGF0ZWRJblZlciI6IjMyLjIwMi4zIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1557 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure that when an animation is used via the
useAnimationfunction and a delay has been provided then that delay gets correctly applied(this PR is a follow up for #47285)
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
If the user provides a delay via
useAnimationsuch delay is ignored:What is the new behavior?
The delay is correctly applied:
Does this PR introduce a breaking change?