If there even is a reason it was provided with the module, I'm curious about the new solution? Imho deprecating treeshakable module providers (with no alternative way?) was not a good decision.

How would you import the formBuilder?

How would you import the formBuilder?

Why not just provide it in root? Its a singleton / stateless anyway. So no need to import it, just use it?

So the old module scope was obviously just wrong? Now I got, why you deprecated this possibility.

Never the less - is there still any posibility to provide a tree-shakable service with a module?

Never the less - is there still any posibility to provide a tree-shakable service with a module?

You can annotate services with the @Injectable({providedIn: 'root'}) decorator to make them tree-shakable. Do you have a specific use-case where a connection to an NgModule is required?

Never the less - is there still any posibility to provide a tree-shakable service with a module?

You can annotate services with the @Injectable({providedIn: 'root'}) decorator to make them tree-shakable. Do you have a specific use-case where a connection to an NgModule is required?

Yeah, your probably right... I actually have none. But isn't the use-case imaginable that a module provides a service that can be used but there's no need to use it? Never the less, I'm coming from a module-based approach. And they are getting lesser anyway. Being a component / framework developer, I just don't like the idea of removing feature because they could be misused.

By the way: was there a reason the FormBuilder was provided with the module? Or was this acatually just a misusage?

By the way: was there a reason the FormBuilder was provided with the module? Or was this acatually just a misusage?

I think it might have been to keep everything organized (if every service was provided in root, the documentation would probably be a mess).

By the way: was there a reason the FormBuilder was provided with the module? Or was this acatually just a misusage?

@angelaki as @sr5434 mentioned above, this was mainly for the code and docs organization.

But if I'm not mistaken this would create a new FormBuilder instance for every import of the FormsModule. Not that this would consume much memory, but ... it is stateless anyway, so no need for several instances.

@angelaki changing the providedIn to "root" would have no effect: an instance of the FormBuilder class would be created once and stored in the root injector. The instance would be reused across an app when injected.

@AndrewKushnir Yeah, sure. Providing it in root was my accepted recommendation. I mean the earlier behavior, providing it with the module.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}