Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): reset() call with null values on nested group #48830

Closed
wants to merge 1 commit into from
Closed

fix(forms): reset() call with null values on nested group #48830

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

Non typed forms allow to pass null to nested groups when calling formGroup.reset(), this commit prevents an undefined access.

fixes #20509

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

@pullapprove pullapprove bot requested a review from dylhunn January 24, 2023 22:08
@JeanMeche
fix(forms): reset() call with null values on nested group
a81ab80 
Non typed forms allow to pass null to nested groups when calling `formGroup.reset()`, this commit prevent an undefined access.

fixes angular#20509
@ngbot ngbot bot added this to the Backlog milestone Jan 25, 2023
dylhunn
dylhunn approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@dylhunn dylhunn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-forms

Looks to already have a passing g3 presubmit.

@pullapprove pullapprove bot requested a review from dylhunn October 10, 2023 22:20
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Oct 10, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Oct 10, 2023

caretaker: windows is a flake.

@dylhunn dylhunn removed their request for review October 10, 2023 22:22
@atscott atscott added the target: patch This PR is targeted for the next patch release label Oct 10, 2023
@atscott
Copy link
Contributor

atscott commented Oct 10, 2023

This PR was merged into the repository by commit ddd7212.

@atscott atscott closed this in ddd7212 Oct 10, 2023
atscott pushed a commit that referenced this pull request Oct 10, 2023
@JeanMeche @atscott
fix(forms): reset() call with null values on nested group (#48830)
51a5baa 
Non typed forms allow to pass null to nested groups when calling `formGroup.reset()`, this commit prevent an undefined access.

fixes #20509

PR Close #48830
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@JeanMeche @ChellappanRajan
fix(forms): reset() call with null values on nested group (angular#48830
46c13c5 
)

Non typed forms allow to pass null to nested groups when calling `formGroup.reset()`, this commit prevent an undefined access.

fixes angular#20509

PR Close angular#48830
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dylhunn dylhunn dylhunn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: forms merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Reactive Form - Formgroup with a nested formgroup throw exception on reset call with null values
4 participants
@JeanMeche @dylhunn @atscott @jessicajaniuk