Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update devinfra orb #49282

Merged
merged 2 commits into from Mar 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 16 additions & 5 deletions .circleci/config.yml
Expand Up @@ -77,7 +77,7 @@ var_11: &only_release_branches
# https://circleci.com/developer/orbs.
orbs:
node: circleci/node@5.0.1
devinfra: angular/dev-infra@1.0.6
devinfra: angular/dev-infra@1.0.8

# Executor Definitions
# https://circleci.com/docs/2.0/reusing-config/#authoring-reusable-executors
Expand All @@ -92,7 +92,7 @@ executors:
type: string
default: medium
docker:
- image: cimg/node:16.10.0
- image: cimg/node:16.13.0
resource_class: << parameters.resource_class >>
working_directory: ~/ng

Expand All @@ -102,7 +102,7 @@ executors:
type: string
default: medium
docker:
- image: cimg/node:16.10.0-browsers
- image: cimg/node:16.13.0-browsers
resource_class: << parameters.resource_class >>
working_directory: ~/ng

Expand Down Expand Up @@ -692,16 +692,27 @@ jobs:
executor: windows-executor
steps:
- checkout
- save_month_to_file
- init_environment

# Setup the proper NodeJS version. The image comes pre-installed with `nvm-windows`.
# Note: This happens immediately after checkout because environment initialization logic
# might rely on Node and shouldn't use the older image-provided NodeJS version.
- run:
name: Install NodeJS version from `.nvmrc`.
command: |
nvm install $(cat .nvmrc)
nvm use $(cat .nvmrc)
- run:
name: Debug information for flakiness of Windows job
command: |
node -v
yarn -v
which node
which yarn
echo "Path: $PATH"
yarn node -v

- save_month_to_file
- init_environment
- restore_cache:
keys:
- *cache_key_win
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
@@ -1 +1 @@
16.10.0
16.13.0
2 changes: 1 addition & 1 deletion WORKSPACE
Expand Up @@ -56,7 +56,7 @@ load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")

nodejs_register_toolchains(
name = "nodejs",
node_version = "16.10.0",
node_version = "16.13.0",
)

# Download npm dependencies.
Expand Down
Expand Up @@ -28,7 +28,7 @@ load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")

nodejs_register_toolchains(
name = "nodejs",
node_version = "16.10.0",
node_version = "16.13.0",
)

# Install our NPM dependencies
Expand Down