fix(compiler-cli): Catch FatalDiagnosticError during template type ch… #49527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
target: patch
atscott
force-pushed
the
ttcerror
branch
3 times, most recently
from
c8882d1
to
bba17f1
Compare
alxhub
approved these changes
Apr 10, 2023
atscott
added
action: merge
|
caretaker note: CI has pre-existing failures at the moment. g3 tests passed. That seems like a good indication that this should be good to go. But feel free to just wait until CI is back in a good state. |
|
@atscott the CI should be in good state right now, could you please rebase this PR (to rerun the CI again)? It looks like this PR wouldn't merge cleanly into 15.2.x. We can merge this PR to 16.0.x and main and we'd need a separate PR for 15.2.x. |
AndrewKushnir
added
the
action: cleanup
…ecking This commit updates the type checking operation to catch `FatalDiagnosticError` and surface them as diagnostics rather than crashing. Fixes angular/vscode-ng-language-service#1881
…s not exported The compiler currently does not check to make sure that directives in the host bindings are exported. These directives are part of the public API of the component so they do have to be.
…nding is not exported
This was referenced Apr 11, 2023
AndrewKushnir
added
target: rc
|
This PR was merged into the repository by commit e949548. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 11, 2023
…ecking (#49527) This commit updates the type checking operation to catch `FatalDiagnosticError` and surface them as diagnostics rather than crashing. Fixes angular/vscode-ng-language-service#1881 PR Close #49527
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ecking
This commit updates the type checking step of the compilation to catch
FatalDiagnosticErrorand surface them as diagnostics rather than crashing.Fixes angular/vscode-ng-language-service#1881