fix(platform-browser): DomEventsPlugin should always be the last plugin to be called for supports().
#50394
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
force-pushed
the
fix/event-manager-plugins-order
branch
2 times, most recently
from
f223c82
to
60a97de
Compare
JeanMeche
commented
May 21, 2023
JeanMeche
force-pushed
the
fix/event-manager-plugins-order
branch
2 times, most recently
from
57065c6
to
fdab3b4
Compare
JeanMeche
force-pushed
the
fix/event-manager-plugins-order
branch
from
fdab3b4
to
9290de1
Compare
waterplea
approved these changes
May 21, 2023
jessicajaniuk
added
action: merge
jessicajaniuk
added
action: review
alxhub
requested changes
Jun 9, 2023
JeanMeche
force-pushed
the
fix/event-manager-plugins-order
branch
5 times, most recently
from
623f32e
to
8edee8b
Compare
JeanMeche
commented
Jun 9, 2023
alxhub
approved these changes
Jun 12, 2023
alxhub
requested changes
Jun 12, 2023
There was a problem hiding this comment.
Looking at the g3 failures, it looks like g3 expects to import EventManagerPlugin from the event_manager.ts file. We could update g3 when we land this change, but I don't think there's a reason to separate EventManagerPlugin into a separate file anymore - how would you feel about keeping it in event_manager.ts?
JeanMeche
force-pushed
the
fix/event-manager-plugins-order
branch
from
8edee8b
to
beaca5d
Compare
|
It makes sense, we're down to 3 changed files. |
JeanMeche
force-pushed
the
fix/event-manager-plugins-order
branch
from
beaca5d
to
ffdc83f
Compare
…ugin to be called for `supports()`. This fixes the issues when `BrowserModule` is not the first module imported. Fixes angular#37149 angular#37850
JeanMeche
force-pushed
the
fix/event-manager-plugins-order
branch
from
ffdc83f
to
2495ce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues when
BrowserModuleis not the first module imported.I choose not to introduce a specific token for the
DomEventsPluginas this would likely be breaking.Fixes #37149 #37850
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?