fix(core): use setTimeout when coalescing tasks in Node.js
#50820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
force-pushed
the
fix/50801
branch
3 times, most recently
from
bfb1911
to
4ef1556
Compare
This commit updates the implementation of the `getNativeRequestAnimationFrame` and checks whether the current code runs in the browser before retrieving `requestAnimationFrame`. `requestAnimationFrame` is not available when the code is running in the Node.js environment. We have to fallback to `setTimeout` for delaying the change detection.
|
// cc @JiaLiPassion @alan-agius4 |
alan-agius4
approved these changes
Jun 23, 2023
AndrewKushnir
requested review from
AndrewKushnir
and removed request for
jessicajaniuk
AndrewKushnir
added
action: review
AndrewKushnir
added
action: presubmit
AndrewKushnir
approved these changes
Jun 23, 2023
AndrewKushnir
added
action: global presubmit
|
TGP. |
AndrewKushnir
added
action: merge
|
Caretaker note: the TGP is "green", this PR is ready for merge. |
angular-robot bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
This commit updates the implementation of the `getNativeRequestAnimationFrame` and checks whether the current code runs in the browser before retrieving `requestAnimationFrame`. `requestAnimationFrame` is not available when the code is running in the Node.js environment. We have to fallback to `setTimeout` for delaying the change detection. PR Close #50820
sunilbaba
pushed a commit
to sunilbaba/angular
that referenced
this pull request
Jul 26, 2023
…#50820) This commit updates the implementation of the `getNativeRequestAnimationFrame` and checks whether the current code runs in the browser before retrieving `requestAnimationFrame`. `requestAnimationFrame` is not available when the code is running in the Node.js environment. We have to fallback to `setTimeout` for delaying the change detection. PR Close angular#50820
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
thomasturrell
pushed a commit
to thomasturrell/angular
that referenced
this pull request
Aug 29, 2023
…#50820) This commit updates the implementation of the `getNativeRequestAnimationFrame` and checks whether the current code runs in the browser before retrieving `requestAnimationFrame`. `requestAnimationFrame` is not available when the code is running in the Node.js environment. We have to fallback to `setTimeout` for delaying the change detection. PR Close angular#50820
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…#50820) This commit updates the implementation of the `getNativeRequestAnimationFrame` and checks whether the current code runs in the browser before retrieving `requestAnimationFrame`. `requestAnimationFrame` is not available when the code is running in the Node.js environment. We have to fallback to `setTimeout` for delaying the change detection. PR Close angular#50820
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the implementation of the
getNativeRequestAnimationFrameand checks whether the current code runs in the browser before retrievingrequestAnimationFrame.requestAnimationFrameis not available when the code is running in the Node.js environment. We have to fallback tosetTimeoutfor delaying the change detection.closes: #50801