fix(router): handle unhandled promise rejections with ErrorHandler

[dzinxed]

Pass errors from calls that returned promises to ErrorHandler. These calls returned promises that could fail but were neither caught nor propagated. This caused "Unhandled (in promise)" errors on the console.

I'll be happy to add some unit test but I want to validate the approach first. Is it OK to inject ErrorHandlers in these two places?

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

If a resolver rejects, "Unhandled (in promise)" errors are shown in the console (aside from the standard Angular navigation error handling). This is because there are calls to methods that return promises, but the results of these promises are never checked.

Issue Number: N/A

What is the new behavior?

Promise rejections are caught and sent to ErrorHandler.handleError.

Does this PR introduce a breaking change?

• Yes
• No

[atscott]

I'll be happy to add some unit test but I want to validate the approach first.

Sounds good.

Is it OK to inject ErrorHandlers in these two places?

Should be. We'll run global presubmit to double check.

[atscott]

Is it OK to inject ErrorHandlers in these two places?

It looks like this would be a breaking change based on the presubmits. Some ErrorHandler implementations inject the Router in order to perform navigations to error pages. If we want to use the ErrorHandler in the Router, it'll have to be changed to injector.get instead.

[atscott]

Note that this would also be superseded by #48910

[atscott]

Closing in favor of #48910

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}