refactor(core): decouple effects from change detection #51049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
reviewed
Jul 15, 2023
There was a problem hiding this comment.
Excellent start @alxhub !
I've left some comments as discussion points, let's catch up on those.
|
oh oh, not merged into 17.next.1 😿 |
alxhub
force-pushed
the
fw/reactivity/effect-timing-update
branch
2 times, most recently
from
5679430
to
f1a9ece
Compare
alxhub
force-pushed
the
fw/reactivity/effect-timing-update
branch
from
f1a9ece
to
29244a6
Compare
alxhub
force-pushed
the
fw/reactivity/effect-timing-update
branch
from
29244a6
to
5d5f2c7
Compare
alxhub
force-pushed
the
fw/reactivity/effect-timing-update
branch
from
5d5f2c7
to
743f454
Compare
pkozlowski-opensource
approved these changes
Sep 1, 2023
alxhub
force-pushed
the
fw/reactivity/effect-timing-update
branch
from
743f454
to
d5b4271
Compare
pullapprove
bot
requested review from
dylhunn,
jessicajaniuk and
pkozlowski-opensource
14 tasks
jessicajaniuk
approved these changes
Sep 5, 2023
Previously effects were queued as they became dirty, and this queue was flushed at various checkpoints during the change detection cycle. The result was that change detection _was_ the effect runner, and without executing CD, effects would not execute. This leads a particular tradeoff: * effects are subject to unidirectional data flow (bad for dx) * effects don't cause a new round of CD (good/bad depending on use case) * effects can be used to implement control flow efficiently (desirable) This commit changes the scheduling mechanism. Effects are now scheduled via the microtask queue. This changes the tradeoffs: * effects are no longer limited by unidirectional data flow (easy dx) * effects registered in the Angular zone will trigger CD after they run (same as `Promise.resolve` really) * the public `effect()` type of effect probably isn't a good building block for our built-in control flow, and we'll need a new internal abstraction. As `effect()` is in developer preview, changing the execution timing is not considered breaking even though it may impact current users.
alxhub
force-pushed
the
fw/reactivity/effect-timing-update
branch
from
d5b4271
to
6119bbc
Compare
alxhub
added
action: merge
AndrewKushnir
approved these changes
Sep 11, 2023
AndrewKushnir
approved these changes
Sep 11, 2023
AndrewKushnir
added
target: minor
pkozlowski-opensource
approved these changes
Sep 12, 2023
|
This PR was merged into the repository by commit 38c9f08. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Previously effects were queued as they became dirty, and this queue was flushed at various checkpoints during the change detection cycle. The result was that change detection _was_ the effect runner, and without executing CD, effects would not execute. This leads a particular tradeoff: * effects are subject to unidirectional data flow (bad for dx) * effects don't cause a new round of CD (good/bad depending on use case) * effects can be used to implement control flow efficiently (desirable) This commit changes the scheduling mechanism. Effects are now scheduled via the microtask queue. This changes the tradeoffs: * effects are no longer limited by unidirectional data flow (easy dx) * effects registered in the Angular zone will trigger CD after they run (same as `Promise.resolve` really) * the public `effect()` type of effect probably isn't a good building block for our built-in control flow, and we'll need a new internal abstraction. As `effect()` is in developer preview, changing the execution timing is not considered breaking even though it may impact current users. PR Close angular#51049
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously effects were queued as they became dirty, and this queue was flushed at various checkpoints during the change detection cycle. The result was that change detection was the effect runner, and without executing CD, effects would not execute. This leads a particular tradeoff:
This commit changes the scheduling mechanism. Effects are now scheduled via the microtask queue. This changes the tradeoffs:
Promise.resolvereally)effect()type of effect probably isn't a good building block for our built-in control flow, and we'll need a new internal abstraction.As
effect()is in developer preview, changing the execution timing is not considered breaking even though it may impact current users.