fix(core): disallow reactive node creation in consumer context #51082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,6 +92,8 @@ class ComputedImpl<T> extends ReactiveNode { | |||
|
|
|||
| protected override readonly consumerAllowSignalWrites = false; | |||
|
|
|||
| protected override readonly consumerAllowReactiveNodeCreation = false; | |||
There was a problem hiding this comment.
This will effectively prevent creation of reactive nodes in angular expressions. Which I think is a good guiderail but calling it out explicitly.
| * Whether new reactive node creation should be allowed when this `ReactiveNode` is the current | ||
| * consumer. | ||
| */ | ||
| protected abstract readonly consumerAllowReactiveNodeCreation: boolean; |
There was a problem hiding this comment.
perf note: depending on how many of those flags we are going to have in the future, we might want to combine them into a single bit-flag numeric field.
This change introduces a check around reactive node creation. On the high level it disallows creation of the new reactive nodes while executing consumer functions (computed, effects, template dirty-checking). It might turn out that this check is too restrictive and there are legitimate use-cases for which we would want to allow reactive node creation while executing computed, effect etc. This is why this PR has infrastructure to enable those checks on the per reactive node type. We do start with the most restrictive version of checks and might gradually releax those checks as we learn more. Closes angular#51055
pkozlowski-opensource
force-pushed
the
reactivity_nodes_creation_in_computed
branch
from
08937e4
to
1d6e9a6
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a check around reactive node creation. On the high level it disallows creation of the new reactive nodes while executing consumer functions (computed, effects, template dirty-checking).
It might turn out that this check is too restrictive and there are legitimate use-cases for which we would want to allow reactive node creation while executing computed, effect etc. This is why this PR has infrastructure to enable those checks on the per reactive node type.
We do start with the most restrictive version of checks and might gradually releax those checks as we learn more.
Closes #51055