Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate PACKAGE_ROOT_URL token #51222

Closed
wants to merge 3 commits into from
Closed

deprecate PACKAGE_ROOT_URL token #51222

wants to merge 3 commits into from

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Jul 31, 2023 •
edited
Loading

2 commits here:

The depreciation should be just a technicality as the token has no purpose anymore.

Does this PR introduce a breaking change?

  • No

@JeanMeche JeanMeche added the area: core Issues related to the framework runtime label Jul 31, 2023
@ngbot ngbot bot added this to the Backlog milestone Jul 31, 2023
@JeanMeche
refactor(core): deprecate PACKAGE_ROOT_URL token
bd2d4d5 
Usage was removed in angular#43884
@JeanMeche
refactor(core): remove unused private provider
a76f0e5 
Both `DEFAULT_PACKAGE_URL_PROVIDER` and `ERROR_COLLECTOR_TOKEN` are unused across the project
@JeanMeche JeanMeche force-pushed the chore/deprecate-package-root branch from 1df4d42 to df08b7e Compare July 31, 2023 20:31
@JeanMeche JeanMeche marked this pull request as ready for review July 31, 2023 20:40
@JeanMeche JeanMeche added the target: minor This PR is targeted for the next minor release label Aug 2, 2023
AndrewKushnir
AndrewKushnir approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 3, 2023
@JeanMeche JeanMeche force-pushed the chore/deprecate-package-root branch from df08b7e to 902eb22 Compare August 3, 2023 07:58
pkozlowski-opensource
pkozlowski-opensource approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@JeanMeche JeanMeche force-pushed the chore/deprecate-package-root branch from 902eb22 to 41439e5 Compare August 3, 2023 21:45
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 3, 2023
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit target: minor This PR is targeted for the next minor release labels Aug 4, 2023
@AndrewKushnir AndrewKushnir added the target: rc This PR is targeted for the next release-candidate label Aug 4, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Aug 7, 2023

This PR was merged into the repository by commit 107be11.

dylhunn pushed a commit that referenced this pull request Aug 7, 2023
@JeanMeche @dylhunn
refactor(core): deprecate PACKAGE_ROOT_URL token (#51222)
c7c0723 
Usage was removed in #43884

PR Close #51222
dylhunn pushed a commit that referenced this pull request Aug 7, 2023
@JeanMeche @dylhunn
refactor(core): remove unused private provider (#51222)
dfa772d 
Both `DEFAULT_PACKAGE_URL_PROVIDER` and `ERROR_COLLECTOR_TOKEN` are unused across the project

PR Close #51222
dylhunn pushed a commit that referenced this pull request Aug 7, 2023
@JeanMeche @dylhunn
docs: add deprecation of PACKAGE_ROOT_URL (#51222)
f79fd35 
PR Close #51222
@dylhunn dylhunn closed this in 56566fe Aug 7, 2023
dylhunn pushed a commit that referenced this pull request Aug 7, 2023
@JeanMeche @dylhunn
refactor(core): remove unused private provider (#51222)
86acbf4 
Both `DEFAULT_PACKAGE_URL_PROVIDER` and `ERROR_COLLECTOR_TOKEN` are unused across the project

PR Close #51222
dylhunn pushed a commit that referenced this pull request Aug 7, 2023
@JeanMeche @dylhunn
docs: add deprecation of PACKAGE_ROOT_URL (#51222)
107be11 
PR Close #51222
thomasturrell pushed a commit to thomasturrell/angular that referenced this pull request Aug 29, 2023
@JeanMeche
refactor(core): deprecate PACKAGE_ROOT_URL token (angular#51222)
b8ddabd 
Usage was removed in angular#43884

PR Close angular#51222
thomasturrell pushed a commit to thomasturrell/angular that referenced this pull request Aug 29, 2023
@JeanMeche
refactor(core): remove unused private provider (angular#51222)
af52c1d 
Both `DEFAULT_PACKAGE_URL_PROVIDER` and `ERROR_COLLECTOR_TOKEN` are unused across the project

PR Close angular#51222
thomasturrell pushed a commit to thomasturrell/angular that referenced this pull request Aug 29, 2023
@JeanMeche
docs: add deprecation of PACKAGE_ROOT_URL (angular#51222)
7072477 
PR Close angular#51222
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@JeanMeche @ChellappanRajan
refactor(core): deprecate PACKAGE_ROOT_URL token (angular#51222)
7ea24b3 
Usage was removed in angular#43884

PR Close angular#51222
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@JeanMeche @ChellappanRajan
refactor(core): remove unused private provider (angular#51222)
5d868e9 
Both `DEFAULT_PACKAGE_URL_PROVIDER` and `ERROR_COLLECTOR_TOKEN` are unused across the project

PR Close angular#51222
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@JeanMeche @ChellappanRajan
docs: add deprecation of PACKAGE_ROOT_URL (angular#51222)
87e2b71 
PR Close angular#51222
@JeanMeche JeanMeche deleted the chore/deprecate-package-root branch February 16, 2024 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeanMeche @AndrewKushnir @dylhunn @pkozlowski-opensource