Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.2.x] refactor(core): throw an error when hydration marker is missing from DOM #51276

Closed
wants to merge 1 commit into from
Closed

[16.2.x] refactor(core): throw an error when hydration marker is missing from DOM #51276

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

Backport of #51170 for 16.2.x

@JeanMeche JeanMeche added the target: rc This PR is targeted for the next release-candidate label Aug 4, 2023
@JeanMeche JeanMeche mentioned this pull request Aug 4, 2023
Closed
2 tasks
@JeanMeche JeanMeche added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 4, 2023
@JeanMeche JeanMeche marked this pull request as ready for review August 4, 2023 19:57
@JeanMeche
refactor(core): throw an error when hydration marker is missing from …
31c1dcc 
…DOM (angular#51170)

non-destructive hydration expects the DOM tree to have the same structure in both places.
With this commit, the app will throw an error if comments are stripped out by the http server (eg by some CDNs).
@JeanMeche JeanMeche added the area: core Issues related to the framework runtime label Aug 4, 2023
@ngbot ngbot bot added this to the Backlog milestone Aug 4, 2023
@AndrewKushnir AndrewKushnir added PullApprove: disable and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 4, 2023
@AndrewKushnir AndrewKushnir changed the title refactor(core): throw an error when hydration marker is missing from DOM [16.2.x] refactor(core): throw an error when hydration marker is missing from DOM Aug 4, 2023
@AndrewKushnir AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Aug 4, 2023
@AndrewKushnir AndrewKushnir mentioned this pull request Aug 4, 2023
Closed
3 tasks
@dylhunn
Copy link
Contributor

dylhunn commented Aug 7, 2023

This PR was merged into the repository by commit b95b5b5.

@dylhunn dylhunn closed this Aug 7, 2023
dylhunn pushed a commit that referenced this pull request Aug 7, 2023
@JeanMeche @dylhunn
refactor(core): throw an error when hydration marker is missing from …
b95b5b5 
…DOM (#51170) (#51276)

non-destructive hydration expects the DOM tree to have the same structure in both places.
With this commit, the app will throw an error if comments are stripped out by the http server (eg by some CDNs).

PR Close #51276
@JeanMeche JeanMeche deleted the chore/ssr-marker2 branch August 8, 2023 21:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@alxhub alxhub Awaiting requested review from alxhub

@jelbourn jelbourn Awaiting requested review from jelbourn

@josephperrott josephperrott Awaiting requested review from josephperrott

@pkozlowski-opensource pkozlowski-opensource Awaiting requested review from pkozlowski-opensource

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime PullApprove: disable target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeanMeche @dylhunn @AndrewKushnir