-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): support TypeScript 5.2 #51334
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| load("//integration:index.bzl", "ng_integration_test") | ||
|
|
||
| ng_integration_test( | ||
| name = "test", | ||
| # Special case for `typings_test_ts52` test as we want to pin | ||
| # `typescript` at version 5.2.x for that test and not link to the | ||
| # root @npm//typescript package. | ||
| pinned_npm_packages = ["typescript"], | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /** | ||
| * @license | ||
| * Copyright Google LLC All Rights Reserved. | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.io/license | ||
| */ | ||
|
|
||
|
|
||
|
|
||
| import * as animations from '@angular/animations'; | ||
| import * as animationsBrowser from '@angular/animations/browser'; | ||
| import * as animationsBrowserTesting from '@angular/animations/browser/testing'; | ||
| import * as common from '@angular/common'; | ||
| import * as commonHttp from '@angular/common/http'; | ||
| import * as commonTesting from '@angular/common/testing'; | ||
| import * as commonHttpTesting from '@angular/common/http/testing'; | ||
| import * as compiler from '@angular/compiler'; | ||
| import * as compilerTesting from '@angular/compiler/testing'; | ||
| import * as core from '@angular/core'; | ||
| import * as coreTesting from '@angular/core/testing'; | ||
| import * as elements from '@angular/elements'; | ||
| import * as forms from '@angular/forms'; | ||
| import * as localize from '@angular/localize'; | ||
| import * as platformBrowser from '@angular/platform-browser'; | ||
| import * as platformBrowserDynamic from '@angular/platform-browser-dynamic'; | ||
| import * as platformBrowserDynamicTesting from '@angular/platform-browser-dynamic/testing'; | ||
| import * as platformBrowserAnimations from '@angular/platform-browser/animations'; | ||
| import * as platformBrowserTesting from '@angular/platform-browser/testing'; | ||
| import * as platformServer from '@angular/platform-server'; | ||
| import * as platformServerInit from '@angular/platform-server/init'; | ||
| import * as platformServerTesting from '@angular/platform-server/testing'; | ||
| import * as router from '@angular/router'; | ||
| import * as routerTesting from '@angular/router/testing'; | ||
| import * as routerUpgrade from '@angular/router/upgrade'; | ||
| import * as serviceWorker from '@angular/service-worker'; | ||
| import * as upgrade from '@angular/upgrade'; | ||
| import * as upgradeStatic from '@angular/upgrade/static'; | ||
| import * as upgradeTesting from '@angular/upgrade/static/testing'; | ||
|
|
||
| export default { | ||
| animations, | ||
| animationsBrowser, | ||
| animationsBrowserTesting, | ||
| common, | ||
| commonTesting, | ||
| commonHttp, | ||
| commonHttpTesting, | ||
| compiler, | ||
| compilerTesting, | ||
| core, | ||
| coreTesting, | ||
| elements, | ||
| forms, | ||
| localize, | ||
| platformBrowser, | ||
| platformBrowserTesting, | ||
| platformBrowserDynamic, | ||
| platformBrowserDynamicTesting, | ||
| platformBrowserAnimations, | ||
| platformServer, | ||
| platformServerInit, | ||
| platformServerTesting, | ||
| router, | ||
| routerTesting, | ||
| routerUpgrade, | ||
| serviceWorker, | ||
| upgrade, | ||
| upgradeStatic, | ||
| upgradeTesting, | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "name": "angular-integration", | ||
| "description": "Assert that users with TypeScript 5.2 can type-check an Angular application", | ||
| "version": "0.0.0", | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "@angular/animations": "file:../../dist/packages-dist/animations", | ||
| "@angular/common": "file:../../dist/packages-dist/common", | ||
| "@angular/compiler": "file:../../dist/packages-dist/compiler", | ||
| "@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli", | ||
| "@angular/core": "file:../../dist/packages-dist/core", | ||
| "@angular/elements": "file:../../dist/packages-dist/elements", | ||
| "@angular/forms": "file:../../dist/packages-dist/forms", | ||
| "@angular/localize": "file:../../dist/packages-dist/localize", | ||
| "@angular/platform-browser": "file:../../dist/packages-dist/platform-browser", | ||
| "@angular/platform-browser-dynamic": "file:../../dist/packages-dist/platform-browser-dynamic", | ||
| "@angular/platform-server": "file:../../dist/packages-dist/platform-server", | ||
| "@angular/router": "file:../../dist/packages-dist/router", | ||
| "@angular/service-worker": "file:../../dist/packages-dist/service-worker", | ||
| "@angular/upgrade": "file:../../dist/packages-dist/upgrade", | ||
| "@types/jasmine": "file:../../node_modules/@types/jasmine", | ||
| "rxjs": "file:../../node_modules/rxjs", | ||
| "typescript": "5.2.1-rc", | ||
| "zone.js": "file:../../dist/zone.js-dist/archive/zone.js.tgz" | ||
| }, | ||
| "scripts": { | ||
| "test": "tsc" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "forceConsistentCasingInFileNames": true, | ||
| "strict": true, | ||
| "noImplicitReturns": true, | ||
| "noFallthroughCasesInSwitch": true, | ||
| "experimentalDecorators": true, | ||
| "module": "commonjs", | ||
| "moduleResolution": "node", | ||
| "outDir": "./dist/out-tsc", | ||
| "rootDir": ".", | ||
| "target": "es5", | ||
| "lib": [ | ||
| "es5", | ||
| "dom", | ||
| "es2015.collection", | ||
| "es2015.iterable", | ||
| "es2015.promise" | ||
| ], | ||
| "types": [], | ||
| }, | ||
| "files": [ | ||
| "include-all.ts", | ||
| "node_modules/@types/jasmine/index.d.ts" | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @devversion since this had to be disabled due to
compiler-cliandlocalizenot using ESM.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good that we have this captured in code now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For later context: We knew this was always not fully compatible- the test just didn't show this because we had
moduleResolutionstill set tonodeand notnodenext