fix(router): Ensure title observable gets latest values #51561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
area: router
target: patch
atscott
force-pushed
the
titleObservable
branch
2 times, most recently
from
b75d2d8
to
93f5ea1
Compare
The data `Observable` is not updated unless there have been changes to the object. The current diffing does not look at `symbol` keys of the object but the `title` property is stored as a private `symbol`. This commit updates the object diffing to include symbols. fixes angular#51401
atscott
force-pushed
the
titleObservable
branch
from
93f5ea1
to
cdb071e
Compare
AndrewKushnir
approved these changes
Aug 29, 2023
atscott
added
action: merge
|
caretaker note: It's green but the presubmit was triggered by someone else so I can't force the status to update https://fusion2.corp.google.com/presubmit/561209378/OCL:561209378:BASE:561402946:1693420793022:7fab9fb3;groups=PossiblyAlreadyFailing,AlreadyFailing/targets |
|
@atscott Looks like this can't merge cleanly into |
jessicajaniuk
added
target: minor
|
This PR was merged into the repository by commit f464e39. |
LayZeeDK
pushed a commit
to LayZeeDK/angular__angular
that referenced
this pull request
Sep 20, 2023
The data `Observable` is not updated unless there have been changes to the object. The current diffing does not look at `symbol` keys of the object but the `title` property is stored as a private `symbol`. This commit updates the object diffing to include symbols. fixes angular#51401 PR Close angular#51561
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
The data `Observable` is not updated unless there have been changes to the object. The current diffing does not look at `symbol` keys of the object but the `title` property is stored as a private `symbol`. This commit updates the object diffing to include symbols. fixes angular#51401 PR Close angular#51561
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data
Observableis not updated unless there have been changes to the object. The current diffing does not look atsymbolkeys of the object but thetitleproperty is stored as a privatesymbol. This commit updates the object diffing to include symbols.fixes #51401