Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(language-service): Enable go to definition of styleUrl #51746

Closed
wants to merge 2 commits into from
Closed

feat(language-service): Enable go to definition of styleUrl #51746

wants to merge 2 commits into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Sep 12, 2023

This commit enables 'go to definition' action for the new 'styleUrl' property

@atscott atscott added the target: minor This PR is targeted for the next minor release label Sep 12, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Sep 12, 2023
AndrewKushnir
AndrewKushnir approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pkozlowski-opensource pkozlowski-opensource added the area: language-service Issues related to Angular's VS Code language service label Sep 13, 2023
@ngbot ngbot bot added this to the Backlog milestone Sep 13, 2023
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Sep 15, 2023
@atscott atscott removed the request for review from JiaLiPassion September 15, 2023 23:37
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit e2416a2.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@atscott @ChellappanRajan
feat(language-service): Enable go to definition of styleUrl (angular#…
782aaf1 
…51746)

This commit enables 'go to definition' action for the new 'styleUrl' property

PR Close angular#51746
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atscott @pkozlowski-opensource @AndrewKushnir