Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs-infra): add version information element to the header #51789

Conversation

ferrorenan
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently we do not have the current version available in the header for easy and quick viewing, we only have it in the footer.

Issue Number: 51548

What is the new behavior?

Add a new element in the header informing the current version, to make it easier for the user to quickly and easily view the current version available.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Deployed aio for 9746761 to: https://ng-dev-previews-fw--pr-angular-angular-51789-aio-l3cor0pe.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@ngbot ngbot bot added this to the Backlog milestone Sep 15, 2023
@ferrorenan
Copy link
Contributor Author

Hey @pkozlowski-opensource @JeanMeche

Do I need to do something else or just wait for approval?!

@H-dymitr
Copy link

H-dymitr commented Oct 1, 2023

@ferrorenan Hi, check commit message('version' is not an allowed scope.)

@ferrorenan ferrorenan force-pushed the implement-header-version-informative branch 2 times, most recently from 9970c03 to ad13b33 Compare October 23, 2023 17:34
@angular-robot angular-robot bot removed the detected: feature PR contains a feature commit label Oct 23, 2023
@ferrorenan ferrorenan changed the title feat(version): add version information element to the header docs-infra(docs-infra): add version information element to the header Oct 23, 2023
@ferrorenan ferrorenan force-pushed the implement-header-version-informative branch from ad13b33 to 9746761 Compare October 23, 2023 17:43
@ferrorenan ferrorenan changed the title docs-infra(docs-infra): add version information element to the header docs(docs-infra): add version information element to the header Oct 23, 2023
@ferrorenan
Copy link
Contributor Author

@H-dymitr Yes, it's was wrong. I adjusted it, now just wait, thank you!

@ferrorenan
Copy link
Contributor Author

Hey @AndrewKushnir

Could you take a look so we can see what's missing and finalize this PR?

@JeanMeche
Copy link
Member

Hi, we're looking at deprecating angular.io in favor of https://angular.dev and suggestions shoud go toward the new site.

Feel free to drop any PR for improvements on the new doc site, thank you.

@JeanMeche JeanMeche closed this Feb 1, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants