Fix scope and injector issues in local compilation mode #51819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmvald
added
action: review
crisbeto
reviewed
Sep 19, 2023
...piler-cli/test/compliance/test_cases/r3_compiler_compliance/ng_modules/empty_fields.local.js
Outdated
Show resolved
Hide resolved
...er-cli/test/compliance/test_cases/r3_compiler_compliance/ng_modules/imports_exports.local.js
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts
Outdated
Show resolved
Hide resolved
devversion
approved these changes
Sep 19, 2023
...er-cli/test/compliance/test_cases/r3_compiler_compliance/ng_modules/imports_exports.local.js
Outdated
Show resolved
Hide resolved
pmvald
force-pushed
the
lcm-fix-scopes
branch
from
00f91b7
to
7e768ea
Compare
devversion
approved these changes
Sep 19, 2023
packages/compiler-cli/src/ngtsc/annotations/ng_module/src/handler.ts
Outdated
Show resolved
Hide resolved
…e when imports/exports are non-array expressions Current implementation assumes that NgModule imports/exports fields are always arrays and thus it concats them for the injector definition. But this is not always the case and imports/exports could be non-arrays such as const variable. Such pattern happens in g3 and so must be addressed.
…n local compilation mode Currently the compiler in local mode assumes that the standalone component imports are array expressions. This is not always true as they can be const variables as well. This change allow non-array expressions for standalone component imports field and passes that expression to the downstream tools such as deps tracker to compute the component's deps in runtime.
…cal compilation mode Standalone component need to include the imported NgModules as part of their dependencies in order to be able to use the injection tokens coming from these NgModules. To do so, in this change the imported NgModules are included in the standalone component compilation scope.
pmvald
force-pushed
the
lcm-fix-scopes
branch
from
7e768ea
to
6431238
Compare
crisbeto
approved these changes
Sep 19, 2023
pmvald
added
action: merge
|
This PR was merged into the repository by commit b44533b. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Sep 20, 2023
…n local compilation mode (#51819) Currently the compiler in local mode assumes that the standalone component imports are array expressions. This is not always true as they can be const variables as well. This change allow non-array expressions for standalone component imports field and passes that expression to the downstream tools such as deps tracker to compute the component's deps in runtime. PR Close #51819
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Sep 20, 2023
…cal compilation mode (#51819) Standalone component need to include the imported NgModules as part of their dependencies in order to be able to use the injection tokens coming from these NgModules. To do so, in this change the imported NgModules are included in the standalone component compilation scope. PR Close #51819
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…e when imports/exports are non-array expressions (angular#51819) Current implementation assumes that NgModule imports/exports fields are always arrays and thus it concats them for the injector definition. But this is not always the case and imports/exports could be non-arrays such as const variable. Such pattern happens in g3 and so must be addressed. PR Close angular#51819
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…n local compilation mode (angular#51819) Currently the compiler in local mode assumes that the standalone component imports are array expressions. This is not always true as they can be const variables as well. This change allow non-array expressions for standalone component imports field and passes that expression to the downstream tools such as deps tracker to compute the component's deps in runtime. PR Close angular#51819
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…cal compilation mode (angular#51819) Standalone component need to include the imported NgModules as part of their dependencies in order to be able to use the injection tokens coming from these NgModules. To do so, in this change the imported NgModules are included in the standalone component compilation scope. PR Close angular#51819
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information