Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: lock file maintenance #51834

Closed
wants to merge 1 commit into from

Conversation

josephperrott
Copy link
Member

Update the lock file.

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Sep 20, 2023
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Sep 20, 2023
@ngbot ngbot bot added this to the Backlog milestone Sep 20, 2023
@devversion
Copy link
Member

do we know where the symbol golden diff is coming from? I can help investigate tomorrow

@josephperrott
Copy link
Member Author

The symbol golden diff seemed to come about after I bumped the babel versions.

@devversion
Copy link
Member

We should potenially try to see if this affects anything with tree-shaking, or why we see the diff

@JeanMeche
Copy link
Member

JeanMeche commented Sep 20, 2023

I can reproduce the symbol changes by only updating terser. (running yarn && yarn upgrade terser@latest)

@JeanMeche JeanMeche removed the action: merge The PR is ready for merge by the caretaker label Sep 20, 2023
@JoostK
Copy link
Member

JoostK commented Sep 20, 2023

I can reproduce the symbol changes by only updating terser. (running yarn && yarn upgrade terser@latest)

Then it's because of terser/terser@33d53e0, which was released in 5.19.4 which this change updates to. So it's likely that the code was always present, just inlined into their (single) usage sites.

@JeanMeche
Copy link
Member

Yeah this is it, the functions added didn't look tree-shakable to me. 👍

@devversion
Copy link
Member

Thanks @JeanMeche for verifying. Yeah, I suspected it being due to inlining. We had similar changes in the past, but want to make sure we are approving these golden changes with reasoning. Thx

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-dev-infra-approvers

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Sep 21, 2023
@josephperrott josephperrott force-pushed the update-lockfile branch 2 times, most recently from 0783b69 to c1834da Compare October 2, 2023 15:21
Update the lock file.
@alxhub
Copy link
Member

alxhub commented Oct 4, 2023

This PR was merged into the repository by commit 5269cae.

@alxhub alxhub closed this in 5269cae Oct 4, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 4, 2023
@josephperrott josephperrott deleted the update-lockfile branch December 21, 2023 14:22
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants