-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: lock file maintenance #51834
build: lock file maintenance #51834
Conversation
ecec1d1
to
903ff4c
Compare
do we know where the symbol golden diff is coming from? I can help investigate tomorrow |
The symbol golden diff seemed to come about after I bumped the babel versions. |
We should potenially try to see if this affects anything with tree-shaking, or why we see the diff |
I can reproduce the symbol changes by only updating terser. (running |
Then it's because of terser/terser@33d53e0, which was released in 5.19.4 which this change updates to. So it's likely that the code was always present, just inlined into their (single) usage sites. |
Yeah this is it, the functions added didn't look tree-shakable to me. 👍 |
Thanks @JeanMeche for verifying. Yeah, I suspected it being due to inlining. We had similar changes in the past, but want to make sure we are approving these golden changes with reasoning. Thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: global-dev-infra-approvers
0783b69
to
c1834da
Compare
Update the lock file.
c1834da
to
6a452b9
Compare
This PR was merged into the repository by commit 5269cae. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Update the lock file. PR Close angular#51834
Update the lock file.