Add defer viewport and hover triggers #51874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for `on hover` and `prefetch on hover` triggers. Some code had to be moved around so it could be reused from the `on interaction` triggers.
Adds support for `on viewport` and `prefetch on viewport` triggers which will load the deferred content when the element comes into the view.
crisbeto
added
action: review
crisbeto
commented
Sep 22, 2023
| } | ||
|
|
||
| /** Keeps track of the registered `viewport` triggers. */ | ||
| class DeferIntersectionManager { |
There was a problem hiding this comment.
I had to keep the injectable for the viewport triggers, because the state ended up leaking between tests.
AndrewKushnir
approved these changes
Sep 22, 2023
AndrewKushnir
removed
the
action: review
|
This PR was merged into the repository by commit 16f5fc4. |
dylhunn
pushed a commit
that referenced
this pull request
Sep 25, 2023
Adds support for `on viewport` and `prefetch on viewport` triggers which will load the deferred content when the element comes into the view. PR Close #51874
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Adds support for `on hover` and `prefetch on hover` triggers. Some code had to be moved around so it could be reused from the `on interaction` triggers. PR Close angular#51874
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Adds support for `on viewport` and `prefetch on viewport` triggers which will load the deferred content when the element comes into the view. PR Close angular#51874
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the implementations for the
on viewportandon hovertriggers indeferblocks. Includes the following commits:feat(core): support deferred hover triggers
Adds support for
on hoverandprefetch on hovertriggers. Some code had to be moved around so it could be reused from theon interactiontriggers.feat(core): support deferred viewport triggers
Adds support for
on viewportandprefetch on viewporttriggers which will load the deferred content when the element comes into the view.