fix(service-worker): throw a critical error when handleFetch fails
#51885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
force-pushed
the
sw-fetch-fail
branch
2 times, most recently
from
2377a08
to
a55431c
Compare
JeanMeche
added
browser: safari
area: service-worker
JeanMeche
added
action: review
On Safari, the cache might fail on methods like `match` with an `Internal error`. Critical errors allows to fallback to `safeFetch()` in the `Driver`. fixes: angular#50378
JeanMeche
force-pushed
the
sw-fetch-fail
branch
from
a55431c
to
62fbab4
Compare
alxhub
approved these changes
Sep 25, 2023
AndrewKushnir
added
action: merge
|
This PR was merged into the repository by commit dcaad16. |
janniemeyer
added a commit
to janniemeyer/angular
that referenced
this pull request
Sep 27, 2023
…ngular#51885). Apply the workaround approved for Angular 16 to Angular 15 as in angular@c3d901e Original description: On Safari, the cache might fail on methods like `match` with an `Internal error`. Critical errors allows to fallback to `safeFetch()` in the `Driver`. fixes: angular#50378 PR Close angular#51885
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Sep 29, 2023
angular#51885 patched a call site that threw an error but there were 2 others call that needed to be wrapped in the same way by a try/catch. `initializeFully` is part of the calls in `responseWith(handleFetch)`. Same angular#51885, throwing `SwCriticalError`allows the driver to fallback to `safeFetch` and ensure `responseWith` doesn't fail. Fixes angular#50378
alxhub
pushed a commit
that referenced
this pull request
Oct 4, 2023
…51960) #51885 patched a call site that threw an error but there were 2 others call that needed to be wrapped in the same way by a try/catch. `initializeFully` is part of the calls in `responseWith(handleFetch)`. Same #51885, throwing `SwCriticalError`allows the driver to fallback to `safeFetch` and ensure `responseWith` doesn't fail. Fixes #50378 PR Close #51960
alxhub
pushed a commit
that referenced
this pull request
Oct 4, 2023
…51960) #51885 patched a call site that threw an error but there were 2 others call that needed to be wrapped in the same way by a try/catch. `initializeFully` is part of the calls in `responseWith(handleFetch)`. Same #51885, throwing `SwCriticalError`allows the driver to fallback to `safeFetch` and ensure `responseWith` doesn't fail. Fixes #50378 PR Close #51960
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ngular#51885) On Safari, the cache might fail on methods like `match` with an `Internal error`. Critical errors allows to fallback to `safeFetch()` in the `Driver`. fixes: angular#50378 PR Close angular#51885
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Safari, the cache might fail on methods like
matchwith anInternal error. Critical errors allows to fallback tosafeFetch()in theDriver.fixes: #50378
NB: This caching will still be broken since apparantly there a bug on Safari. This fix will only allow the app to recover from the bug. It can be considered as a workaround.