Linker fixes to handle @ syntax #51979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
commented
Oct 2, 2023
| @@ -120,6 +120,48 @@ describe('FileLinker', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('block syntax support', () => { | |||
There was a problem hiding this comment.
Context for these tests: I couldn't find a better place to test the linker with different version strings.
JoostK
approved these changes
Oct 2, 2023
packages/compiler-cli/linker/src/file_linker/partial_linkers/partial_linker.ts
Show resolved
Hide resolved
Adds some logic to enable parsing of block syntax in the linker. Note that the syntax is only enabled on code compiled with Angular v17 or later.
Increases the `minVersion` of component declarations that use bloks to v17 in order to indicate to users that they need to update if the library they're using is on the new syntax, while preserving backwards compatibility for libraries that do not use the syntax.
crisbeto
force-pushed
the
block-syntax-linker
branch
from
102c1aa
to
77ebf32
Compare
crisbeto
added
action: merge
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Oct 3, 2023
Enables the new `@` block syntax by default by removing the `enabledBlockTypes` flags. There are still some internal flags that allow special use cases to opt out of the block syntax, like during XML parsing and when compiling older libraries (see angular#51979).
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Oct 3, 2023
Enables the new `@` block syntax by default by removing the `enabledBlockTypes` flags. There are still some internal flags that allow special use cases to opt out of the block syntax, like during XML parsing and when compiling older libraries (see angular#51979).
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Oct 3, 2023
Enables the new `@` block syntax by default by removing the `enabledBlockTypes` flags. There are still some internal flags that allow special use cases to opt out of the block syntax, like during XML parsing and when compiling older libraries (see angular#51979).
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Oct 3, 2023
Enables the new `@` block syntax by default by removing the `enabledBlockTypes` flags. There are still some internal flags that allow special use cases to opt out of the block syntax, like during XML parsing and when compiling older libraries (see angular#51979).
|
This PR was merged into the repository by commit 1beef49. |
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Oct 3, 2023
Enables the new `@` block syntax by default by removing the `enabledBlockTypes` flags. There are still some internal flags that allow special use cases to opt out of the block syntax, like during XML parsing and when compiling older libraries (see angular#51979).
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Oct 3, 2023
Enables the new `@` block syntax by default by removing the `enabledBlockTypes` flags. There are still some internal flags that allow special use cases to opt out of the block syntax, like during XML parsing and when compiling older libraries (see angular#51979).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Adds some logic to enable parsing of block syntax in the linker. Note that the syntax is only enabled on code compiled with Angular v17 or later. PR Close angular#51979
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ngular#51979) Increases the `minVersion` of component declarations that use bloks to v17 in order to indicate to users that they need to update if the library they're using is on the new syntax, while preserving backwards compatibility for libraries that do not use the syntax. PR Close angular#51979
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some fixes in the linker to parse blocks for libraries compiled with v17 or above and to enable block parsing through the linker. Split into the following commits:
fix(compiler): enable block syntax in the linker
Adds some logic to enable parsing of block syntax in the linker. Note that the syntax is only enabled on code compiled with Angular v17 or later.
fix(compiler): update the minVersion if component uses block syntax
Increases the
minVersionof component declarations that use blocks to v17 in order to indicate to users that they need to update if the library they're using is on the new syntax, while preserving backwards compatibility for libraries that do not use the syntax.