fix(core): adjust toSignal types to handle more common cases #51991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
approved these changes
Oct 3, 2023
pkozlowski-opensource
added
area: core
pkozlowski-opensource
added
the
action: cleanup
|
Marking it as cleanup since it needs the public API update |
alxhub
force-pushed
the
interop/to-signal/types
branch
from
bbd78ff
to
84248fa
Compare
This commit cleans up the signatures of `toSignal` to better handle the types of situations that it might be used in, and produce better type inference results. Fixes angular#50687 Fixes angular#50591 Co-authored-by: Andrew Scott <atscott@google.com>
alxhub
force-pushed
the
interop/to-signal/types
branch
from
84248fa
to
a7f067f
Compare
pullapprove
bot
requested review from
atscott,
jessicajaniuk and
pkozlowski-opensource
alxhub
added
target: minor
pkozlowski-opensource
approved these changes
Oct 10, 2023
pkozlowski-opensource
added
the
action: review
jessicajaniuk
approved these changes
Oct 10, 2023
alxhub
added
action: merge
|
This PR was merged into the repository by commit 5411864. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…#51991) This commit cleans up the signatures of `toSignal` to better handle the types of situations that it might be used in, and produce better type inference results. Fixes angular#50687 Fixes angular#50591 Co-authored-by: Andrew Scott <atscott@google.com> PR Close angular#51991
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans up the signatures of
toSignalto better handle the types of situations that it might be used in, and produce better type inference results.Fixes #50687
Fixes #50591