New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): upgrade warning to logged error for lazy-loaded LCP images #52004
Conversation
…ges using NgOptimizedImage Upgrade the existing warning so it now logs an error instead, when an LCP element is determined to not be usings the `priority` attribute. Error is logged, not thrown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atcastle thanks Alex!
TGP. |
FYI, TGP is "green". |
Caretaker note: TGP is "green", this PR is ready for merge. |
This PR was merged into the repository by commit dde3fda. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…ges using NgOptimizedImage (angular#52004) Upgrade the existing warning so it now logs an error instead, when an LCP element is determined to not be usings the `priority` attribute. Error is logged, not thrown. PR Close angular#52004
This PR upgrades the existing warning when an NgOptimizedImage is discovered to be the LCP element and not given the
priority
attribute to an error. Not usingpriority
causes the LCP image to be lazy-loaded and can significantly hurt image performance. This error is only logged in dev.This PR is a pared-back version of #51748. As this error is logged, not thrown, it is no longer a breaking change and does not require the functionality to turn the error off in testbed scenarios. CC: @AndrewKushnir