refactor(platform-browser): remove withNoDomReuse function
#52057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
action: review
angular-robot
bot
added
the
detected: breaking change
jessicajaniuk
approved these changes
Oct 5, 2023
pkozlowski-opensource
approved these changes
Oct 6, 2023
AndrewKushnir
removed
the
action: review
AndrewKushnir
force-pushed
the
drop_with_no_dom_reuse
branch
from
30947f2
to
9d06b67
Compare
AndrewKushnir
added
action: presubmit
This commit removes the `withNoDomReuse` function to minimize public API. The `withNoDomReuse` function used to disable DOM reuse, which is the main feature of the `provideClientHydration()`. The `withNoDomReuse()` function was in the "developer preview" mode, so the removal happens without prior deprecation. BREAKING CHANGE: The `withNoDomReuse()` function was removed from the public API. If you need to disable hydration, you can exclude the `provideClientHydration()` call from provider list in your application (which would disable hydration features for the entire application) or use `ngSkipHydration` attribute to disable hydration for particular components. See this guide for additional information: https://angular.io/guide/hydration#how-to-skip-hydration-for-particular-components.
AndrewKushnir
force-pushed
the
drop_with_no_dom_reuse
branch
from
9d06b67
to
69cab96
Compare
|
Caretaker notes:
|
AndrewKushnir
added
action: merge
AndrewKushnir
added
the
merge: caretaker note
|
This PR was merged into the repository by commit dbc14eb. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…#52057) This commit removes the `withNoDomReuse` function to minimize public API. The `withNoDomReuse` function used to disable DOM reuse, which is the main feature of the `provideClientHydration()`. The `withNoDomReuse()` function was in the "developer preview" mode, so the removal happens without prior deprecation. BREAKING CHANGE: The `withNoDomReuse()` function was removed from the public API. If you need to disable hydration, you can exclude the `provideClientHydration()` call from provider list in your application (which would disable hydration features for the entire application) or use `ngSkipHydration` attribute to disable hydration for particular components. See this guide for additional information: https://angular.io/guide/hydration#how-to-skip-hydration-for-particular-components. PR Close angular#52057
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
withNoDomReusefunction to minimize public API. ThewithNoDomReusefunction used to disable DOM reuse, which is the main feature of theprovideClientHydration().The
withNoDomReuse()function was in the "developer preview" mode, so the removal happens without prior deprecation.BREAKING CHANGE:
The
withNoDomReuse()function was removed from the public API. If you need to disable hydration, you can exclude theprovideClientHydration()call from provider list in your application (which would disable hydration features for the entire application) or usengSkipHydrationattribute to disable hydration for particular components. See this guide for additional information: https://angular.io/guide/hydration#how-to-skip-hydration-for-particular-components.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?