Narrow types in event listeners inside conditional blocks #52069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
force-pushed
the
control-flow-guard
branch
from
7cc0c55
to
97b8b05
Compare
atscott
approved these changes
Oct 9, 2023
packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.ts
Outdated
Show resolved
Hide resolved
…de if blocks Since expressions in event listener are added inside of a callback, type narrowing won't apply to them anymore. These changes add the logic to create a guard expression that will re-narrow the expression in the callback. Fixes angular#52052.
…de switch blocks Since expressions in event listener are added inside of a callback, type narrowing won't apply to them anymore. These changes add the logic to create a guard expression that will re-narrow the expression in the callback. Fixes angular#52052.
crisbeto
force-pushed
the
control-flow-guard
branch
from
97b8b05
to
f339366
Compare
|
Rebased and addressed the feedback. |
|
Caretaker note: please ignore the Windows failures. The failures are unrelated and the CI seems to have gotten stuck in the flaky state. |
crisbeto
added
action: merge
|
This PR was merged into the repository by commit ac0d5dc. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…de if blocks (angular#52069) Since expressions in event listener are added inside of a callback, type narrowing won't apply to them anymore. These changes add the logic to create a guard expression that will re-narrow the expression in the callback. Fixes angular#52052. PR Close angular#52069
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…de switch blocks (angular#52069) Since expressions in event listener are added inside of a callback, type narrowing won't apply to them anymore. These changes add the logic to create a guard expression that will re-narrow the expression in the callback. Fixes angular#52052. PR Close angular#52069
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we rely on native
ifandswitchblocks to do the type narrowing for us in the new control flow syntax. This works for most cases, except for event listeners. Since event listener expressions are inside callback functions, type narrowing doesn't apply to them anymore. These changes work around it by reconstructing an expression to re-narrow the type in such cases.Fixes #52052.