fix(core): host directive validation not picking up duplicate directives on component node #52073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
jessicajaniuk
approved these changes
Oct 6, 2023
| if (seenDirectives.has(current)) { | ||
| throw new RuntimeError( | ||
| RuntimeErrorCode.DUPLICATE_DIRECTITVE, | ||
| `Directive ${current.type.name} matches multiple times on the same element. ` + |
There was a problem hiding this comment.
nit: this needs the ngDevMode check to make the error message tree shakable.
There was a problem hiding this comment.
This function is prefixed with ngDevMode && at call sites, so the entire function should be tree-shaken-away in prod.
AndrewKushnir
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
@crisbeto LGTM 👍
(I think it'd be great to run TGP for this change)
AndrewKushnir
added
action: global presubmit
crisbeto
force-pushed
the
52072/host-directives-validation
branch
from
163e561
to
bf2b102
Compare
|
Passing TGP. I also pushed a minor perf improvement. |
crisbeto
added
action: presubmit
…ves on component node Fixes that, depending on the matching and import order, in some cases we weren't throwing the error saying that a directive matched multiple times on the same element. Fixes angular#52072.
crisbeto
force-pushed
the
52072/host-directives-validation
branch
from
bf2b102
to
5043325
Compare
crisbeto
added
action: merge
|
This PR was merged into the repository by commit 7368b8a. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ves on component node (angular#52073) Fixes that, depending on the matching and import order, in some cases we weren't throwing the error saying that a directive matched multiple times on the same element. Fixes angular#52072. PR Close angular#52073
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that, depending on the matching and import order, in some cases we weren't throwing the error saying that a directive matched multiple times on the same element.
Fixes #52072.